Repository navigation
Conversation
When the normal run produces only lightweight changes (such as a network reconnect) and does not recreate or restart the container, return `force_mod_watch: True` so the state system still invokes `mod_watch` for a watched trigger. Previously the watched-state trigger was silently dropped in this case - for example, a watched config-file change would not force-replace the container if `docker_container.running` happened to also reconnect a network during the same run. Heavy-change keys (`container_id`, `state`, `image`, `forced_update`) already indicate the container was recreated or restarted, so `mod_watch` is not needed in those cases. The `force_mod_watch` return key is handled by the state system since saltstack/salt#68960 (currently on Salt's master branch). Older Salt versions do not act on it. See: saltstack/salt#68958
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 42.10% 42.32% +0.21%
==========================================
Files 26 27 +1
Lines 6545 6620 +75
Branches 1138 1139 +1
==========================================
+ Hits 2756 2802 +46
- Misses 3542 3571 +29
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the normal run produces only lightweight changes (such as a network reconnect) and does not recreate or restart the container, return
force_mod_watch: Trueso the state system still invokesmod_watchfor a watched trigger. Previously the watched-state trigger was silently dropped in this case - for example, a watched config-file change would not force-replace the container ifdocker_container.runninghappened to also reconnect a network during the same run.Heavy-change keys (
container_id,state,image,forced_update) already indicate the container was recreated or restarted, somod_watchis not needed in those cases.The
force_mod_watchreturn key is handled by the state system since saltstack/salt#68960 (currently on Salt's master branch). Older Salt versions do not act on it.See: saltstack/salt#68958
Merge requirements satisfied?
[NOTICE] Bug fixes or new features require tests.
Commits signed with GPG?
No