Repository navigation
Conversation
docker_network.present looked up "IPV6Address" (uppercase V) in the network-inspect data returned by docker.inspect_network, whose actual key is "IPv6Address" (lowercase v, same casing as the adjacent "IPv4Address" lookup on the previous line). The KeyError was silently swallowed by the surrounding try/except, so on every network recreation the reconnect call dropped the container's ipv6_address argument and Docker auto-assigned a random IPv6 from the pool. Containers with declared static IPv6 addresses would drift off them after any recreate, and subsequent docker_container.running states attempting to reclaim the declared addresses would fail with "403 Address already in use" because the wrong container was still holding them.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
==========================================
+ Coverage 42.10% 42.36% +0.25%
==========================================
Files 26 27 +1
Lines 6545 6610 +65
Branches 1138 1138
==========================================
+ Hits 2756 2800 +44
- Misses 3542 3563 +21
Partials 247 247
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker_network.present looked up "IPV6Address" (uppercase V) in the network-inspect data returned by docker.inspect_network, whose actual key is "IPv6Address" (lowercase v, same casing as the adjacent "IPv4Address" lookup on the previous line). The KeyError was silently swallowed by the surrounding try/except, so on every network recreation the reconnect call dropped the container's ipv6_address argument and Docker auto-assigned a random IPv6 from the pool. Containers with declared static IPv6 addresses would drift off them after any recreate, and subsequent docker_container.running states attempting to reclaim the declared addresses would fail with "403 Address already in use" because the wrong container was still holding them.
Merge requirements satisfied?
[NOTICE] Bug fixes or new features require tests.
Commits signed with GPG?
No