Skip to content

fix(acp): reject ineligible authentication methods - #155

Merged
YoungSx merged 1 commit into
developfrom
fix/acp-auth-type-147
Sep 1, 2026
Merged

fix(acp): reject ineligible authentication methods#155
YoungSx merged 1 commit into
developfrom
fix/acp-auth-type-147

Conversation

@YoungSx

@YoungSx YoungSx commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • allowlist ACP auth-method discriminators so only agent methods reach authenticate
  • enforce the same rule at the protocol client's outgoing wire boundary
  • add localized unsupported-method guidance and protocol/selection/transport regression coverage

Verification

  • dotnet build src/SalmonEgg.Presentation.Core/SalmonEgg.Presentation.Core.csproj -c Release --nologo
  • dotnet test --project tests/SalmonEgg.Acp.Tests/SalmonEgg.Acp.Tests.csproj -c Release --timeout 10m --output Normal (346/346)
  • dotnet test --project tests/SalmonEgg.Application.Tests/SalmonEgg.Application.Tests.csproj -c Release --timeout 8m --output Normal (120/120)
  • Focused Presentation.Core auth tests (12/12) and localization tests (209/209)

The full Presentation.Core host has pre-existing load-sensitive instability outside this change: a StartViewModel timeout and an unhandled ChatViewModel cancellation can terminate the host (exit 134).

🤖 Generated with Claude Code

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
salmonegg Ready Ready Preview Sep 1, 2026 5:31pm UTC

@YoungSx
YoungSx merged commit 3d61c96 into develop Sep 1, 2026
17 checks passed
@YoungSx
YoungSx deleted the fix/acp-auth-type-147 branch September 1, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant