Repository navigation
fix(console): a delivery that Fruitback gave up says so on Notes (FRU-245) - #323
Merged
Merged
Conversation
…-245) A note that an address did not take read « Not delivered yet », whether the worker still tries or gave up (FRU-122). One it gave up now reads « Not delivered: Fruitback stopped trying »: it will not arrive by itself. « Send again » sends both, as before. The test fails on main. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Score de confiance : 4/5 · ✅ Rien de bloquant · Le changement peut être fusionné : il ne fait qu'ajouter un libellé conditionnel pour une livraison abandonnée. Le type de note.delivery.state (la valeur 'gave-up') n'est pas visible dans le contexte, donc sa compilation n'a pas pu être confirmée.
Niveau lite · anthropic/claude-haiku-5.5 · 0,003 $ · Le résumé, le diagramme et la liste des constats sont à la fin de la description de la PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not critical: one cell of the Notes page. Follow-up of #313, from the P2 of its lite review, agreed with the orchestrator.
What changes
A note that a REST address did not take carries
delivery.statein the route of #306:waiting(the worker still tries) orgave-up(it stopped, FRU-122). The cell said « Not delivered yet » for both. A note the worker gave up now reads « Not delivered: Fruitback stopped trying », in the same accent, 13px/600. It will not arrive by itself. « Send again » stays and sends both, as before (POST …/notes/<id>/retrytakes both).French added
Proof
e2e/console-notes.spec.ts: « a delivery the worker gave up says so, and « Send again » still sends it ». A note of the second page is given up. Its cell reads the new sentence in the accent, a note still tried reads « Not delivered yet », and « Send again » sends the given-up one and takes the alert away. It fails onmain. The spec passes locally, 17 tests; console unit tests 119.Not verified
The look of the longer sentence beside « Send again » at 390 px; the cell wraps, as the others do.
🤖 Generated with Claude Code
Sakuga Review · Score de confiance : 4/5
Le changement peut être fusionné : il ne fait qu'ajouter un libellé conditionnel pour une livraison abandonnée. Le type de
note.delivery.state(la valeur'gave-up') n'est pas visible dans le contexte, donc sa compilation n'a pas pu être confirmée.Résumé
La PR affiche « Non livrée : Fruitback a cessé d'essayer » sur une note dont le worker a abandonné la livraison, et garde « Envoyer à nouveau » disponible. Le libellé français est ajouté dans messages.fr.ts et un test e2e couvre les deux libellés ainsi que le renvoi. J'ai vérifié que la clé est une phrase anglaise complète, donc
tretombe correctement sur l'anglais si la traduction manque. Je n'ai pas pu vérifier le type dedelivery.stateni la logique de renvoi côté worker.Diagramme
%%{init: {'theme': 'neutral'}}%% flowchart LR A["NoteRow"] --> B["note.delivery.state"] B -->|gave-up| C["Not delivered: Fruitback stopped trying"] B -->|autre| D["Not delivered yet"] C --> E["Send again"] D --> ENon relu
note.deliveryet la valeur'gave-up'ne sont pas dans le contexte ; si la valeur n'existe pas, le typecheck échouegave-upet le renvoi (POST /retry) n'est pas dans le diff ; le comportement réel du renvoi n'a pas été vérifiéRevues (1) · Dernier commit relu : fix(console): a delivery that Fruitback gave up... · Niveau
lite·anthropic/claude-haiku-5.5· 0,003 $