Repository navigation
test(console): a press on « Sign out » waits for My account at rest (FRU-248) - #293
Merged
Merged
Conversation
…FRU-248) main was red on 30c62f8: console-cookie-session.spec.ts pressed « Sign out » while My account still read the list of the browsers. The list arrives above the button, which goes down 53 px; a press that starts before and ends after is lost (the button has focus, nothing is sent, the page stays). The page snapshot of the failed run shows that state, and holding GET /console/sessions between the press and the release reproduces it each time. The four presses of this spec now open My account through one helper, which waits for the list. No retry, no fixed wait. The shift itself is a defect of the screen, fixed apart. Co-Authored-By: Claude Opus 5.5 <[email protected]>
There was a problem hiding this comment.
Score de confiance : 5/5 · ✅ Rien de bloquant · Le changement ne touche que des tests e2e et peut être fusionné : il ajoute un helper qui attend que la liste des navigateurs soit affichée avant de cliquer sur « Sign out ».
Niveau lite · anthropic/claude-haiku-5.5 · 0,001 $ · Le résumé, le diagramme et la liste des constats sont à la fin de la description de la PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red on 30c62f8 (jobe2e):e2e/console-cookie-session.spec.ts:199, « ends the session on the worker when the person signs out », fails, retry included. This makes the test right. It is not a defect of the sign-out, and not a state shared between specs.Cause, measured
The test opens My account and presses « Sign out » at once. My account (FRU-248, #269) draws its buttons, then reads the list « Where you are signed in », which arrives above « Sign out ». The button goes down 53 px. A press that starts before the list and ends after it is lost: the button has focus, no request leaves, and the page stays, with no message.
[active], and no « You are still signed in ».GET /console/sessionsbetween the press and the release; the button moves from y=765 to y=818 and the address stays/account. With the list already there (control), the same press leads to/setup.What changes
e2e/console-cookie-session.spec.tsonly: its four presses on My account go throughopenAccount, which waits for the row of this browser in the list. No retry, no fixed wait, nothing run in series.console-account.spec.tsalready waits for the list.Proof
The two specs that open My account on a real worker, on four workers, four times each: 84 passed locally. Earlier, on
mainas it is, the four specs that start a worker passed 348/348 locally on four workers: the race needs the load of the CI to show, which is why the proof of the cause is the held request above and not a red run on my machine.Not in this pull request
The shift is a defect of the screen too: a person can lose the same click. Reserving the room of the list in
account.tsxis the next pull request, with the held request as its failing test.🤖 Generated with Claude Code
Sakuga Review · Score de confiance : 5/5
Le changement ne touche que des tests e2e et peut être fusionné : il ajoute un helper qui attend que la liste des navigateurs soit affichée avant de cliquer sur « Sign out ».
Résumé
Le commit extrait dans un helper openAccount l'ouverture de My account suivie de l'attente de la région « Where you are signed in » contenant « Console · this browser », puis remplace l'appui sur le lien My account par cet helper dans quatre endroits du spec console-cookie-session. Le diff a été relu en entier ; le helper et ses quatre appels sont cohérents, et la locator getByRole/getByText utilisée existe dans le diff. Je n'ai pas pu vérifier la page My account elle-même ni le libellé exact dans l'application.
Non relu
Revues (1) · Dernier commit relu : test(console): a press on « Sign out » waits fo... · Niveau
lite·anthropic/claude-haiku-5.5· 0,001 $