Repository navigation
test(e2e): open the list again once its first read failed (FRU-268) - #288
Merged
Merged
Conversation
The list gives focus when it opens. On a busy runner the read failed after that, and focus stayed on the close button: the test failed twice in one run of the suite in three parts. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
There was a problem hiding this comment.
Score de confiance : 5/5 · ✅ Rien de bloquant · Le changement de test peut être fusionné : il ne modifie que un spec e2e et n'introduit pas de défaut vérifiable dans le code produit.
Niveau lite · anthropic/claude-haiku-5.5 · 0,001 $ · Le résumé, le diagramme et la liste des constats sont à la fin de la description de la PR.
Contributor
Author
|
@sakuga-review review balanced |
Contributor
There was a problem hiding this comment.
Score de confiance : 4/5 · ✅ Rien de bloquant · Modification de test e2e uniquement ; peut être fusionnée, aucun défaut bloquant identifié.
Niveau balanced · anthropic/claude-sonnet-5.5 · 0,015 $ · Le résumé, le diagramme et la liste des constats sont à la fin de la description de la PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One spec,
e2e/read-failure.spec.ts. Part of FRU-268 (a faster E2E job), independent of #285 and #286.Why
"a first read that fails (503) is not an empty list, and « Try again » reads again" failed twice in one run (first try and retry) of the suite cut in three parts (#286, run 1058), on
expect(retry).toBeFocused().The list chooses where focus goes when it opens (
open()inpackages/widget/src/sidebar.ts): the first note, else « Try again » when the read failed, else the close button. The test clicks « Show every note of this page » right after mounting the widget. On a busy runner the read had not failed yet when the list opened, so focus went to the close button, and nothing moves it later. The widget does what it says; the test raced its read.What changes
Once the list says the notes could not be read, the test closes it with Escape and opens it again, then checks that « Try again » has focus. Same promise, no race. The control after it is unchanged.
Verified
read-failure.spec.tsandconsole-frame.spec.ts, 21 passed.Not verified
open(), not measured against a failing run.🤖 Generated with Claude Code
Sakuga Review · Score de confiance : 4/5
Modification de test e2e uniquement ; peut être fusionnée, aucun défaut bloquant identifié.
Résumé
Le test read-failure rouvre la liste après l'échec de la première lecture, pour contourner un problème de focus (FRU-268). Le diff est limité à un test e2e et rien dans le code applicatif n'est modifié. Je n'ai pas pu vérifier le comportement du widget (fermeture par Escape, nouvelle lecture à la réouverture).
Non relu
Revues (2) · Dernier commit relu : test(e2e): open the list again once its first r... · Niveau
balanced·anthropic/claude-sonnet-5.5· 0,015 $