Fix MCP Registry workflow npm version - #320
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The MCP Registry workflow ran
npm ciwith the Node 22 runner's bundled npm 10.9.8, while this repository declares and locks dependencies with npm 11.14.1. npm 10 rejected the otherwise valid lockfile with false missing React 18 peer entries.Fix
Install the repository-declared npm 11.14.1 before
npm ci, matching the existing Documentation workflow.Validation
npm ci --dry-run --ignore-scriptsgit diff --check