Repository navigation
Consume events from the topic exchange - #363
Open
Uxío (Uxio0) wants to merge 1 commit into
Open
Uxío (Uxio0) wants to merge 1 commit into
Uxío (Uxio0) wants to merge 1 commit into
Conversation
Uxío (Uxio0)
force-pushed
the
uxio/pla-2114-decoder-service-consume-transaction-service-events-from-the
branch
from
October 6, 2026 15:10
5df2502 to
9c4c6ef
Compare
Bind the queue to the Transaction Service topic exchange only for EXECUTED_MULTISIG_TRANSACTION, the one event type the service processes.
Uxío (Uxio0)
force-pushed
the
uxio/pla-2114-decoder-service-consume-transaction-service-events-from-the
branch
from
October 6, 2026 16:03
9c4c6ef to
84c52f7
Compare
Uxío (Uxio0)
marked this pull request as ready for review
October 6, 2026 16:06
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
./run_tests.shpre-commit run -aWhat was wrong? 👾
Closes PLA-2114
Decoder Service consumes from the legacy fanout exchange
safe-transaction-service-events, which is going to be removed from Transaction Service (PLA-2111).How was it fixed? 🎯
RABBITMQ_AMQP_EXCHANGEdefault is nowsafe-transaction-service-events-with-topics. The exchange is declared as durabletopic, the same as Transaction Service.*.EXECUTED_MULTISIG_TRANSACTION.*, the one type the service processes. The type lives inCONSUMED_EVENT_TYPES, used by both the binding andEventsService._is_processable_event.INCOMING_ETHER) do not.Notes:
RABBITMQ_AMQP_EXCHANGE=safe-transaction-service-eventsmust change or remove it, or startup fails withPRECONDITION_FAILED.