Skip to content

Consume events from the topic exchange - #363

Open
Uxío (Uxio0) wants to merge 1 commit into
mainfrom
uxio/pla-2114-decoder-service-consume-transaction-service-events-from-the
Open

Uxío (Uxio0) wants to merge 1 commit into
mainfrom
uxio/pla-2114-decoder-service-consume-transaction-service-events-from-the

Conversation

@Uxio0

@Uxio0 Uxío (Uxio0) commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Make sure these boxes are checked! 📦✅

  • You ran ./run_tests.sh
  • You ran pre-commit run -a

What was wrong? 👾

Closes PLA-2114

Decoder Service consumes from the legacy fanout exchange safe-transaction-service-events, which is going to be removed from Transaction Service (PLA-2111).

How was it fixed? 🎯

  • RABBITMQ_AMQP_EXCHANGE default is now safe-transaction-service-events-with-topics. The exchange is declared as durable topic, the same as Transaction Service.
  • The queue is bound only with *.EXECUTED_MULTISIG_TRANSACTION.*, the one type the service processes. The type lives in CONSUMED_EVENT_TYPES, used by both the binding and EventsService._is_processable_event.
  • Tests against a real RabbitMQ: a bound type reaches the queue, unbound types (e.g. INCOMING_ETHER) do not.

Notes:

  • Existing queues keep their old binding to the fanout. RabbitMQ delivers a message to a queue only once even if two bindings match, and the binding is deleted together with the fanout exchange (PLA-2111). Until then the queue still gets every event through the fanout, so the narrowing has effect after PLA-2111.
  • Any environment that sets RABBITMQ_AMQP_EXCHANGE=safe-transaction-service-events must change or remove it, or startup fails with PRECONDITION_FAILED.

@Uxio0
Uxío (Uxio0) force-pushed the uxio/pla-2114-decoder-service-consume-transaction-service-events-from-the branch from 5df2502 to 9c4c6ef Compare October 6, 2026 15:10
Bind the queue to the Transaction Service topic exchange only for EXECUTED_MULTISIG_TRANSACTION, the one event type the service processes.
@Uxio0
Uxío (Uxio0) force-pushed the uxio/pla-2114-decoder-service-consume-transaction-service-events-from-the branch from 9c4c6ef to 84c52f7 Compare October 6, 2026 16:03
@Uxio0
Uxío (Uxio0) marked this pull request as ready for review October 6, 2026 16:06
@Uxio0
Uxío (Uxio0) requested a review from a team as a code owner October 6, 2026 16:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T16:08:41.905321Z 84c52f7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant