Repository navigation
Bump sqlmodel to 0.0.47, sqladmin to 0.32.0 and alembic to 1.20.0 - #361
Merged
Merged
Conversation
- sqlmodel 0.0.42 -> 0.0.47 (sqlalchemy 2.0.52 -> 2.0.54) - sqladmin 0.31.1 -> 0.32.0 - alembic 1.19.2 -> 1.20.0 sqlmodel 0.0.47 types the model `__init__` from the fields. Fix the new mypy errors: - Cast `eth_typing.ABI` values to `list[dict]` when creating `Abi`. - Remove unused `type: ignore` comments in `TimeStampedSQLModel`. - Remove the `name` argument from the `Project` test, the model has no such field.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
`list[dict] | dict` does not accept the `eth_typing` ABI TypedDicts, so every caller needed a cast. `Sequence[Mapping[str, Any]] | Mapping[str, Any]` accepts both plain dicts and the ABI TypedDicts. The DB column is set by `sa_column`, so it does not change.
Moisés (moisses89)
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
./run_tests.sh(not run locally, CI runs the tests)pre-commit run -aWhat was wrong? 👾
Dependabot PR #358 fails the mypy step. sqlmodel 0.0.47 now types the model
__init__from the fields, so mypy checks every argument passed to the models.Supersedes the sqlmodel, sqladmin and alembic part of #358.
How was it fixed? 🎯
sqlmodel0.0.42 -> 0.0.47. It also movessqlalchemy2.0.52 -> 2.0.54.sqladmin[full]0.31.1 -> 0.32.0 andalembic1.19.2 -> 1.20.0.Abi.abi_json(and theget_abi/get_or_create_abiparams) asSequence[Mapping[str, Any]] | Mapping[str, Any].list[dict] | dictdoes not accept theeth_typingABI TypedDicts,Mappingdoes. This also removes the old cast inAbiService. The DB column is set bysa_column, so it does not change.type: ignorecomments inTimeStampedSQLModel.nameargument from theProjecttest. The model and the table have no such column.UTCDateTimethe default type for datetime fields. All datetime fields here setsa_type=DateTime(timezone=True), so no migration is needed.SQLAlchemy 2.1
SQLAlchemy stays on 2.0.x: sqlmodel 0.0.47 requires
SQLAlchemy>=2.0.14,<2.1.0. The What's New in SQLAlchemy 2.1 guide applies once sqlmodel allows 2.1. sqlmodel changes are in its release notes.