Repository navigation
Finish fresh access token - #5
Merged
Merged
Conversation
d-s-codappix
force-pushed
the
finish-fresh-access-token
branch
7 times, most recently
from
September 30, 2025 13:30
fa037cb to
9f963bd
Compare
The extension states it is compatible with TYPO3 12 and 13, but only had 13 within require-dev, breaking local and CI setup for TYPO3 13.
The project already has a `.php-cs-fixer.dist.php` file, but missed the dependency, this is now added.
As this project is hosted on GitHub and already has tests and CGL, etc. This should be run on CI to ensure it is always checked for all contributions.
The changes affected the code under test, but the test was not adopted. The new class `OidcConfiguration` is final and can't be stubbed. We therefore need to use `GeneralUtility::addInstance()` to not touch existing code.
d-s-codappix
force-pushed
the
finish-fresh-access-token
branch
from
October 7, 2025 09:23
9f963bd to
7c1ef3c
Compare
Establish ci
In order to ease development of missing tests.
Use early return to reduce nesting level and make code easier to read.
The method already existed, but did not return the fresh token. The new token is saved for later usage, to not force API users to update settings of service to still work, e.g. for long running processes where the token might expire again.
d-s-codappix
force-pushed
the
finish-fresh-access-token
branch
from
October 7, 2025 11:21
7c1ef3c to
4f7e792
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.