Repository navigation
[BUGFIX] Escape slashes in marker replacement - #5
Merged
Merged
Conversation
Markers whose key contains a slash were never replaced in the frontend output. The regular expression that searches for markers is built with a slash as delimiter, but the marker keys were escaped without telling the escaping function about that delimiter. A key such as "foo/bar" therefore ended the pattern early, and the resulting expression either failed or matched the wrong text. Editors saw the raw marker instead of its value. The marker keys are now escaped with the slash delimiter in mind, so every character of a key is treated as literal text. Markers containing slashes, dots or other characters with a special meaning in regular expressions are replaced like any other marker.
s12r
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markers whose key contains a slash were never replaced in the frontend output. The regular expression that searches for markers is built with a slash as delimiter, but the marker keys were escaped without telling the escaping function about that delimiter. A key such as "foo/bar" therefore ended the pattern early, and the resulting expression either failed or matched the wrong text. Editors saw the raw marker instead of its value.
The marker keys are now escaped with the slash delimiter in mind, so every character of a key is treated as literal text. Markers containing slashes, dots or other characters with a special meaning in regular expressions are replaced like any other marker.