Repository navigation
fix(when): report a --when the read-back cannot place as not confirmed - #453
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read-back's
whenCheck.holdstreats a valueplaceWhencannot model as held, soadd,project addandeditreported "confirmed" for a weekday name, a weekday oreveningwith a time, or a phrase Things understood, after checking only that Things applied the write.Cut from
origin/main; it does not depend on #449.Changes
whenPlaced(when.go) says whether a value, as sent, is oneplaceWhenmodels:anytime,someday,today,evening,tomorrow, empty,HH:MM, a date, or a date and time.add/project add: when the item is found and the--whenis not one of those, warn on stderr with where the item is and report it not confirmed, exit 0, with the item's uuid.edit/project edit: once the read-back sees the edit applied, the same. The existing phrase-only edit path (reason: when) is unchanged, and the new case reuses its output shape (printUnconfirmedEdit) and reason.agents.md,commands.md,SKILL.md.Before / after
things add "Buy oat milk" --when friday, which Things files on Friday:things showwould (confirmed).warning: the CLI cannot check where --when "friday" files an item, so the to-do is not confirmed; it was created scheduled for 2026-10-16. Runthings showto check. stdoutCreated, not confirmed (--when not checked): "Buy oat milk" (<uuid>). Under--json:{"uuid": "<uuid>", "title": "Buy oat milk", "confirmed": false, "reason": "when"}.things edit <uuid> --when evening@6pm --notes x, once applied:Applied, not confirmed (--when not checked): "…" (<uuid>), with the same JSON shape.Tests
TestAddWhenUnplaced(friday, friday@18:00, evening@6pm, for to-dos and projects in both output modes, plus a date@time that is still confirmed),TestEditWhenUnplaced, andTestAddWhenPhraseIgnoredupdated: a phrase Things understood is now unconfirmed.make testandmake lintpass.