Repository navigation
fix(lookup): report a project not found for every ref shape in a project lookup - #448
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolveRefbuilt its own refusals for row numbers, row-like refs (#12,07) and uuid-shaped refs, and they all said "task". Soopen --project 99andproject edit <unknown uuid>reported a task not found, while a title miss already said project (#444, #445).resolveRefnow picks one noun ("task", or "project" for a project lookup) and every refusal uses it, in the message and in the JSONkind:stale list cache(old listing, other database, unreadable cache file)empty referenceambiguous task(the token stays the same; the text andkindsay project)Task lookups print exactly what they did before.
Example
Tests
TestRunProjectRefNotFoundKindcovers the four not-found shapes onopen --projectandproject edit(all eight cases fail on main).TestRunProjectRefRefusalKindcovers a stale row, an empty ref and an ambiguous ref.SKILL.md and docs/content/agents.md now say these refusals carry
kindproject.Follow-ups (not in this PR)
resolveProjectRefonly falls back to the to-do check ondb.TaskNotFoundError. So a to-do titled exactly#12or2026givesproject not foundforproject edit '#12'where a plain title givesnot a project.today.