Repository navigation
Put a run example's fold toggle inside its stage - #149
Merged
Merged
Conversation
The landing shows the schema toggle under the copy, above the pane on phones, but the page put it after the pane, so Tab visited thirty panel controls before reaching it. The generator now writes the toggle between the demo and the panel, so the order matches the screen; the layout doesn't move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On phones the landing shows the schema toggle under the copy and above the pane, but the page wrote it after the pane, so Tab went through about thirty panel controls before reaching it. The generator now writes a run example's fold toggle inside the stage, between the demo and the panel, so the page order and the screen agree; the code body still follows the stage. Measured positions are identical on desktop and phone, and only the landing uses foldCode.