Repository navigation
Widen an interval's range around its value again - #146
Merged
Merged
Conversation
Since #131 passed the interval's verbose form through as given, a value with no min or max locked the range to the value itself: [20, 80] spanned 20-80 instead of 0.3.1's 0-240, pinning both handles at the ends, in the markup form too. The control now derives an absent bound from its two ends, as the shorthand and a verbose slider do, and the test checks the handles' range, not just the value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression from #131, caught in the release review. An interval given a value but no min or max now spanned only that value ([20, 80] gave a 20-80 track, both handles pinned at the ends), where 0.3.1 gave 0-240; the markup form regressed the same way. The control now derives an absent bound from its two ends, the same way the shorthand and a verbose slider do, so 0.3.1's ranges are back; explicit bounds and the shorthand are unchanged. The existing test only checked the value, so it now checks the handles' range too, and fails without the fix.