Repository navigation
feat: pass n_jobs to KNN defaults - #69
Merged
Merged
Conversation
KNeighborsClassifier and KNeighborsRegressor were built without n_jobs, unlike RandomForest. Propagate the estimator's n_jobs. Closes P1-6 of the ML defaults improvements plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements P1-6 from the ML defaults improvements plan (
docs/ml-defaults-improvements.md).Changes
KNeighborsClassifierandKNeighborsRegressorare now constructed withn_jobs=self.n_jobs, matching RandomForest.Tests
n_jobs(classifier and regressor).All 252 tests pass; ruff + format clean.