Repository navigation
feat: OHE min_frequency knob to collapse rare categories - #68
Merged
Merged
Conversation
- Add ohe_min_frequency (default 5) to PoniardPreprocessor; int is an absolute count, float is a fraction of samples, None keeps every category - Rare categories collapse into sklearn's infrequent bucket, composing with the existing handle_unknown='ignore' - Disable the knob in the two existing tests that assert exact OHE output on 5-row toy data; document the default in the preprocessing guide Closes P1-5 of the ML defaults improvements plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements P1-5 from the ML defaults improvements plan (
docs/ml-defaults-improvements.md).Changes
ohe_min_frequencyparameter toPoniardPreprocessor(default5).None: keep every category.OneHotEncoder(drop="if_binary", handle_unknown="ignore", sparse_output=False, min_frequency=5).infrequent_sklearnbucket, composing correctly withhandle_unknown="ignore"(unseen categories still map to all-zeros).Tests
Nonepreserves every category; float thresholds work as fractions.All 251 tests pass; coverage 89.4% (gate 85%); ruff + format clean.