Repository navigation
feat: regression default metrics — RMSE first, MAPE only for positive targets - #66
Merged
Merged
Conversation
… targets - Default metrics become [neg_root_mean_squared_error, neg_mean_absolute_error, r2] (RMSE is the primary sort key; neg_mean_squared_error was outlier-dominated) - neg_mean_absolute_percentage_error is included only when the target is strictly positive, avoiding astronomical values on zero-containing targets (MAPE epsilon-floors the denominator) - get_target_info() now reports whether a regression target is positive - Bump scikit-learn floor to >=1.4.0 for neg_root_mean_squared_error Closes P0-3 of the ML defaults improvements plan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements P0-3 from the ML defaults improvements plan (
docs/ml-defaults-improvements.md).Changes
["neg_root_mean_squared_error", "neg_mean_absolute_error", "r2"].neg_mean_squared_errorwas outlier-dominated;neg_median_absolute_errordropped.neg_mean_absolute_percentage_erroris only included when the target is strictly positive. MAPE epsilon-floors the denominator in sklearn, silently producing astronomical values whenycontains zeros.get_target_info()now reports whether a regression target is positive (positivekey).scikit-learnfloor to>=1.4.0(required forneg_root_mean_squared_error).Tests
All 244 tests pass; ruff + format clean.