Repository navigation
add: --no-probe to skip the SSH server check on the server command - #67
Merged
Merged
Conversation
Owner
|
Hi, @Kiraprint, thank you for both the PRs! I will take a look in the next couple of days as soon as I have some time. They both look good to me, the no-probe just cleans up a todo and can probably be merged in as is and the relay url fix (adding the missing wiring through to the proxy command) is also needed, there I just have to merge my changes to the address lookup code with the relay changes. Actually looks like it might not even interfere with my address lookup changes at all, will look at it in more detail in a bit ^^ |
Starting the server opens a TCP connection to the local sshd, reads the
banner and drops it, which sshd logs as an aborted preauth connection:
sshd-session[4449]: Connection from ::1 port 43360 on ::1 port 22
sshd-session[4449]: kex_exchange_identification: Connection closed by remote host [preauth]
`--no-probe` skips `is_ssh_server_available()`. The default is unchanged: the
check still runs and still bails when no SSH server answers.
Refs rustonbsd#61
Owner
|
Hi @Kiraprint @Kirgod666, thanks for the PR, will look at your relay one next. All tested on windows and linux with and without |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #61.
iroh-ssh serveropens a TCP connection to the local sshd at startup, reads the banner and drops it. sshd sees a real connection being opened and closed without a handshake:--no-probeskipsis_ssh_server_available():Default behaviour is unchanged — the check still runs and still fails fast when nothing answers on the port:
18 insertions / 2 deletions: a
skip_server_probebuilder flag, the--no-probearg onserver, and a guard around the probe.Two notes:
--no-probeafter your first suggestion; happy to rename to--skip-server-probeif you prefer.service installdoes not forward the flag yet — the installed unit still probes. Say the word and I'll thread it throughServiceParamsin a follow-up (or in this PR if you'd rather have it complete).