Repository navigation
docs: describe held-out scoring as the code performs it - #5
Merged
Merged
Conversation
The held-out split is scored twice, both after selection ends: once for the baseline policy and once for the final policy (rsi_framework/core.py). README and DESIGN.md said "measured once".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation-only.
README.md(feature list) andDESIGN.md(item 5, Held-out Isolation) said the held-out split is "measured once". Inrsi_framework/core.py(around lines 500-509) it is scored twice, both after selection ends: once for the baseline policy (baseline_heldout) and once for the final policy (heldout). Both now say the held-out data is scored only after selection ends, once for the baseline policy and once for the final policy. The generated results block in the README is untouched.Checks run locally (same as
.github/workflows/ci.yml): unittest discover (35 tests),python -m rsi_framework.reporting --results results --readme README.md --check(consistent), byte-for-byte replay offirst_run.json,history.jsonl,metrics.csv,progress.svg, and benchmark re-run compared moduloruntime_seconds. All pass.