Skip to content

fix(render): avoid implicit baseline and artifact claims - #138

Merged
newhoggy merged 2 commits into
mainfrom
issue-137-render-report-guidance
Oct 10, 2026
Merged

newhoggy merged 2 commits into
mainfrom
issue-137-render-report-guidance

Conversation

@newhoggy

Copy link
Copy Markdown
Contributor

When a CLI report had no baseline or artifact URL, its Markdown promised future main-branch deltas and claimed a coverage-summary upload. A run URL alone was also omitted.

The renderer now describes the missing baseline without CI assumptions, omits artifact claims without an explicit URL, and renders run links independently. Existing explicit full-summary artifact links retain their label. The PR-build workflow adds the actual uploaded artifact URL to its comment and run summary, labeled as LCOV and Markdown. The archived report keeps its run link because the artifact URL becomes available after upload. Reference, example and contributor documentation explain the behavior; no new flags or public fields are introduced.

Closes #137

Implementation plan: #137 (comment)

Verification (all passed locally and repeated after rebase onto current origin/main; commands explicitly targeted this worktree):

  • cargo fmt --check
  • actionlint .github/workflows/ci.yml
  • cargo test --locked render::tests — 34 renderer tests, including missing baseline and all absent/empty/supplied URL combinations
  • cargo test --locked --all-targets — 541 tests
  • cargo test --locked --doc
  • cargo clippy --locked --all-targets -- -D warnings
  • cargo run --locked -- lint-markers
  • cargo +1.88.0 test --locked --all-targets
  • cargo +1.88.0 test --locked --doc
  • RUSTDOCFLAGS='-D warnings' cargo doc --locked --no-deps --document-private-items
  • cargo test --locked --test doc_links_test — 13 passed after the review fix

Review: inspected the committed diff and surrounding renderer/workflow code once. Fixed the stale baseline notice in README.md:60 in a separate commit. No findings skipped, unrelated follow-ups, or departures from the plan. Hosted artifact upload/comment behavior and Linux/Windows execution require GitHub CI; fork-token behavior was not exercised locally.

@github-actions

Copy link
Copy Markdown

Coverage

Total: 99.41% ⚪ 0 pp vs main

Comparing 3e32bc8..77bec66 (merge-base → PR head)

No per-file coverage changes vs main.

Touched files absent from every coverage report (4)
  • .github/workflows/ci.yml
  • CONTRIBUTING.md
  • README.md
  • docs/reference.md

These files may contain no executable code or may have been omitted from the coverage run.

Patch coverage

Patch: 100% (40/40 new lines covered)

File Patch Uncovered new lines
src/render.rs 100% (40/40) —

📦 Full per-file coverage summary · run summary

Baseline: the report published for 38365d8, 1 commit before the merge-base, which has none. The deltas also include whatever those commits changed.

@github-actions

Copy link
Copy Markdown

PR build

Measured and rendered by this PR's own patchcov build. No baseline deltas; see the release Coverage report for those.

Coverage

Total: 99.41%

Comparing 3e32bc8..77bec66 (merge-base → PR head)

No baseline report supplied. Per-file deltas and indirect coverage changes require a baseline report.

Touched files absent from every coverage report (4)
  • .github/workflows/ci.yml
  • CONTRIBUTING.md
  • README.md
  • docs/reference.md

These files may contain no executable code or may have been omitted from the coverage run.

Patch coverage

Patch: 100% (40/40 new lines covered)

File Patch Uncovered new lines
src/render.rs 100% (40/40) —

run summary

📦 PR-build coverage report (LCOV and Markdown)

@newhoggy
newhoggy added this pull request to the merge queue Oct 10, 2026
Merged via the queue into main with commit ed34235 Oct 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(render): avoid action-specific baseline and artifact claims in CLI reports

1 participant