Repository navigation
fix(render): avoid implicit baseline and artifact claims - #138
Conversation
CoverageTotal: 99.41% ⚪ 0 pp vs Comparing No per-file coverage changes vs Touched files absent from every coverage report (4)
These files may contain no executable code or may have been omitted from the coverage run. Patch coveragePatch: 100% (40/40 new lines covered)
📦 Full per-file coverage summary · run summary Baseline: the report published for |
PR buildMeasured and rendered by this PR's own patchcov build. No baseline deltas; see the release Coverage report for those. CoverageTotal: 99.41% Comparing No baseline report supplied. Per-file deltas and indirect coverage changes require a baseline report. Touched files absent from every coverage report (4)
These files may contain no executable code or may have been omitted from the coverage run. Patch coveragePatch: 100% (40/40 new lines covered)
|
When a CLI report had no baseline or artifact URL, its Markdown promised future main-branch deltas and claimed a
coverage-summaryupload. A run URL alone was also omitted.The renderer now describes the missing baseline without CI assumptions, omits artifact claims without an explicit URL, and renders run links independently. Existing explicit full-summary artifact links retain their label. The PR-build workflow adds the actual uploaded artifact URL to its comment and run summary, labeled as LCOV and Markdown. The archived report keeps its run link because the artifact URL becomes available after upload. Reference, example and contributor documentation explain the behavior; no new flags or public fields are introduced.
Closes #137
Implementation plan: #137 (comment)
Verification (all passed locally and repeated after rebase onto current origin/main; commands explicitly targeted this worktree):
cargo fmt --checkactionlint .github/workflows/ci.ymlcargo test --locked render::tests— 34 renderer tests, including missing baseline and all absent/empty/supplied URL combinationscargo test --locked --all-targets— 541 testscargo test --locked --doccargo clippy --locked --all-targets -- -D warningscargo run --locked -- lint-markerscargo +1.88.0 test --locked --all-targetscargo +1.88.0 test --locked --docRUSTDOCFLAGS='-D warnings' cargo doc --locked --no-deps --document-private-itemscargo test --locked --test doc_links_test— 13 passed after the review fixReview: inspected the committed diff and surrounding renderer/workflow code once. Fixed the stale baseline notice in README.md:60 in a separate commit. No findings skipped, unrelated follow-ups, or departures from the plan. Hosted artifact upload/comment behavior and Linux/Windows execution require GitHub CI; fork-token behavior was not exercised locally.