Repository navigation
ci: require the Coverage check on main - #136
Merged
Merged
Conversation
CoverageTotal: 99.4% ⚪ 0 pp vs Comparing No per-file coverage changes vs Touched files absent from every coverage report (3)
These files may contain no executable code or may have been omitted from the coverage run. Patch coverageNo new executable lines added by this diff. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
Adds
Coverage(GitHub Actions integration 15368) to the main ruleset's required checks. CONTRIBUTING now lists seven checks and explains that Coverage satisfies the merge queue requirement as a skipped job; workflow comments match. Thresholds, permissions, fork handling, and executable workflow configuration stay as configured in #131.The implementation plan records the prerequisites:
coverage-baseline; PR #132's Coverage job downloaded it and skipped recomputation. Its comment shows deltas without a recomputed note.version: latestremains a future source of risk. ci: also dogfood the pull request's own patchcov build #134 owns testing the PR-built binary.actions: readremains: the action uses the artifact download API, whose installation-token permissions require Actions read. A token without this permission was not experimentally tested.Verification
Ran from this feature worktree, with every Cargo command explicitly targeting its Cargo.toml, before commit and after fetching/rebasing onto current main:
actionlint .github/workflows/ci.yml,git diff --check, JSON/workflow/docs consistency assertions: passed; seven unique required checks, all pinned to Actions.cargo fmt --check: passed.cargo test --locked --all-targets: 540 passed.cargo test --locked --doc: 1 passed.cargo clippy --locked --all-targets -- -D warnings: passed. The first attempt reported a missing generated.rmeta; immediate retry and the full repeated suites passed.cargo run --locked -- lint-markers: passed.cargo +1.88.0 test --locked --all-targets: 540 passed.cargo +1.88.0 test --locked --doc: 1 passed.RUSTDOCFLAGS='-D warnings' cargo doc --locked --no-deps --document-private-items: passed.All seven checks in this PR's GitHub CI run passed, including Linux/macOS/Windows tests. Coverage downloaded the existing main baseline and skipped recomputation; its comment reports 99.4% overall coverage, zero delta, and no new executable lines.
Review and live configuration
Reviewed the committed three-file diff against
origin/main...HEADand its surrounding workflow/ruleset/docs: no actionable findings, no fixes or skipped findings. No departure from the plan or unrelated follow-ups.This PR's Coverage run passed in 35 seconds. Applied the Coverage requirement to active ruleset 24650034. Fresh ruleset and effective
mainrules readbacks confirm all seven required checks are pinned to GitHub Actions; an exact payload comparison confirms every other live setting was preserved.A post-change merge queue/release smoke test is not verified: it requires a merge, which this issue-to-pr run does not perform.