Skip to content

ci: require the Coverage check on main - #136

Merged
newhoggy merged 1 commit into
mainfrom
issue-133-require-coverage-check
Oct 10, 2026
Merged

newhoggy merged 1 commit into
mainfrom
issue-133-require-coverage-check

Conversation

@newhoggy

@newhoggy newhoggy commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #133

Adds Coverage (GitHub Actions integration 15368) to the main ruleset's required checks. CONTRIBUTING now lists seven checks and explains that Coverage satisfies the merge queue requirement as a skipped job; workflow comments match. Thresholds, permissions, fork handling, and executable workflow configuration stay as configured in #131.

The implementation plan records the prerequisites:

Verification

Ran from this feature worktree, with every Cargo command explicitly targeting its Cargo.toml, before commit and after fetching/rebasing onto current main:

  • actionlint .github/workflows/ci.yml, git diff --check, JSON/workflow/docs consistency assertions: passed; seven unique required checks, all pinned to Actions.
  • cargo fmt --check: passed.
  • cargo test --locked --all-targets: 540 passed.
  • cargo test --locked --doc: 1 passed.
  • cargo clippy --locked --all-targets -- -D warnings: passed. The first attempt reported a missing generated .rmeta; immediate retry and the full repeated suites passed.
  • cargo run --locked -- lint-markers: passed.
  • cargo +1.88.0 test --locked --all-targets: 540 passed.
  • cargo +1.88.0 test --locked --doc: 1 passed.
  • RUSTDOCFLAGS='-D warnings' cargo doc --locked --no-deps --document-private-items: passed.

All seven checks in this PR's GitHub CI run passed, including Linux/macOS/Windows tests. Coverage downloaded the existing main baseline and skipped recomputation; its comment reports 99.4% overall coverage, zero delta, and no new executable lines.

Review and live configuration

Reviewed the committed three-file diff against origin/main...HEAD and its surrounding workflow/ruleset/docs: no actionable findings, no fixes or skipped findings. No departure from the plan or unrelated follow-ups.

This PR's Coverage run passed in 35 seconds. Applied the Coverage requirement to active ruleset 24650034. Fresh ruleset and effective main rules readbacks confirm all seven required checks are pinned to GitHub Actions; an exact payload comparison confirms every other live setting was preserved.

A post-change merge queue/release smoke test is not verified: it requires a merge, which this issue-to-pr run does not perform.

@github-actions

Copy link
Copy Markdown

Coverage

Total: 99.4% ⚪ 0 pp vs main

Comparing 9f564e3..0337281 (merge-base → PR head)

No per-file coverage changes vs main.

Touched files absent from every coverage report (3)
  • .github/rulesets/main.json
  • .github/workflows/ci.yml
  • CONTRIBUTING.md

These files may contain no executable code or may have been omitted from the coverage run.

Patch coverage

No new executable lines added by this diff.

📦 Full per-file coverage summary · run summary

@newhoggy
newhoggy added this pull request to the merge queue Oct 10, 2026
Merged via the queue into main with commit 3e32bc8 Oct 10, 2026
7 checks passed
@newhoggy newhoggy mentioned this pull request Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: make the Coverage check required once it is proven

1 participant