Skip to content

remove NOP File::flush from fs tests #165739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Nov 10, 2026
+0 −4
Merged

remove NOP File::flush from fs tests #165739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions library/std/src/fs/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2753,7 +2753,6 @@ fn test_hidden_file_truncation() {
.open(&path)
.unwrap();
file.write("hidden world!".as_bytes()).unwrap();
file.flush().unwrap();
drop(file);

// Create a new file by truncating the existing one.
Expand Down Expand Up @@ -3298,7 +3297,6 @@ fn test_dir_write_file() {
let dir = check!(Dir::open(tmpdir.path()));
let mut f = check!(dir.open_file_with("foo.txt", &OpenOptions::new().write(true).create(true)));
check!(f.write(b"bar"));
check!(f.flush());
drop(f);
let mut f = check!(File::open(tmpdir.join("foo.txt")));
let mut buf = [0u8; 3];
Expand All @@ -3311,7 +3309,6 @@ fn test_dir_remove_file() {
let tmpdir = tmpdir();
let mut f = check!(File::create(tmpdir.join("foo.txt")));
check!(f.write(b"bar"));
check!(f.flush());
drop(f);
let dir = check!(Dir::open(tmpdir.path()));
check!(dir.remove_file("foo.txt"));
Expand Down Expand Up @@ -3368,7 +3365,6 @@ fn test_dir_open_dir() {
let mut f =
check!(dir2.open_file_with("bar.txt", &OpenOptions::new().create(true).write(true)));
check!(f.write(b"baz"));
check!(f.flush());
drop(f);
let dir3 = check!(dir1.open_dir("foo"));
let mut f = check!(dir3.open_file("bar.txt"));
Expand Down
Loading