Repository navigation
error when a command line flag lowers a -F forbid - #165669
Open
Albab-Hasan wants to merge 1 commit into
Open
Albab-Hasan wants to merge 1 commit into
Albab-Hasan wants to merge 1 commit into
Conversation
a later `-A`, `-W` or `--force-warn` for a lint forbidden by an earlier `-F` was silently ignored while the same order as crate attributes is E0453. command line levels now go through `insert_spec` like attributes so `-F dead_code -A dead_code` is E0453 too. lint groups also hard error instead of the `forbidden_lint_groups` future compat warning since the command line never let them lower a forbid.
rustbot
added
S-waiting-on-review
Collaborator
|
Error: Failed to set assignee to
Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
Member
|
r? compiler |
Member
|
cc @folkertdev |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-F x -A xon the command line silently kept the forbid while the crate attribute form is E0453. now both error. groups hard error too instead of theforbidden_lint_groupsfcw since the cli never let them lower a forbid.the skip started as the #70918 hack for #70819 and #86970 moved it into
add_command_line. related #133346 #81670cc @jyn514