Repository navigation
Conversation
Some platforms like UEFI do not support real sub-processes. Hoever, it is possible to launch a program from another. Thus, while Command::spawn is not possible on UEFI, APIs which wait for the result, (such as Command::output) are fine. Similar to what was done for Command::output in past, make Command::status impl platform specific, i.e. move it into sys/process/mod.rs. Signed-off-by: Ayush Singh <[email protected]>
rustbot
added
A-process
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
joboet
requested changes
Nov 8, 2026
| @@ -145,7 +145,12 @@ impl Command { | |||
| } | |||
| } | |||
|
|
|||
| pub fn output(command: &mut Command) -> io::Result<(ExitStatus, Vec<u8>, Vec<u8>)> { | |||
| pub fn cmd_exec( | |||
Member
There was a problem hiding this comment.
Does this need to be public? I'd have thought this to be a private helper.
Contributor
Author
There was a problem hiding this comment.
Nope, it does not. Fixed. Thanks
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Use a custom implementation for Command::status for UEFI, that does not rely on Command::spawn. While I am only writing one for UEFI, judging by the implementation of output just above this, other platforms might also add their own in the future. Signed-off-by: Ayush Singh <[email protected]>
Contributor
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some platforms like UEFI do not support real sub-processes. Hoever, it
is possible to launch a program from another. Thus, while
Command::spawn is not possible on UEFI, APIs which wait for the
result, (such as Command::output) are fine.
Similar to what was done for Command::output in past (#105458), make
Command::status impl platform specific, i.e. move it into
sys/process/mod.rs.