Repository navigation
[beta] Clippy backport - #165499
Closed
flip1995 wants to merge 3 commits into
Closed
[beta] Clippy backport#165499flip1995 wants to merge 3 commits into
flip1995 wants to merge 3 commits into
Conversation
…g#17752) Implements part of rust-lang/rust-clippy#17485 Unleaking a leaked `Box` pointer isn't well defined, so we shouldn't be suggesting to change `into_raw` into `leak`. This needs to be backported to beta and ideally would be synced before a new beta is branched off. r? flip1995 changelog: [`nonnull_unchecked_on_box_ptr`]: Don't suggest `Box::leak`
…ust-lang#17828) fixes rust-lang/rust-clippy#17799 changelog: [`wildcard_imports`]: fix infinite loop on macro generated glob imports
Skip anonymous AssocItems generated by RPITIT. Fixes rust-lang/rust-clippy#17940 changelog: [arbitrary_source_item_ordering]: Fix ICE caused by synthetic associated items generated by RPITIT
rustbot
added
S-waiting-on-author
This was referenced Nov 5, 2026
Merged
flip1995
marked this pull request as ready for review
November 5, 2026 14:29
Collaborator
|
cc @rust-lang/clippy |
rustbot
added
S-waiting-on-review
Collaborator
|
|
JonathanBrouwer
added
beta-nominated
Merged
Member
|
Rolled up into #165513 |
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
Member
|
(actually I think github should mark this PR is merged if we keep it open) |
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
[beta] backports Cherry picked: * #165497 * #165499 - rust-lang/rust-clippy#17752 (was already last beta, but we didn't manage to get the proper fixed merged in time like we planned) - rust-lang/rust-clippy#17828 - rust-lang/rust-clippy#17941 r? @ghost
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
[beta] backports Cherry picked: * #165497 * #165499 - rust-lang/rust-clippy#17752 (was already last beta, but we didn't manage to get the proper fixed merged in time like we planned) - rust-lang/rust-clippy#17828 - rust-lang/rust-clippy#17941 r? @ghost
Member
Author
|
For some reason GitHub didn't auto-close it. 🤷 |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? Mark-Simulacrum
We want to backport 3 ICE/infinite loop fixes:
Box::leakinnonnull_unchecked_on_box_ptrrust-clippy#17752 (was already last beta, but we didn't manage to get the proper fixed merged in time like we planned)wildcard_importsinfinite loop on macro generated glob imports rust-clippy#17828arbitrary_source_item_orderingrust-clippy#17941