Repository navigation
c-variadic: remove stale cfg(bootstrap) comment - #165496
Merged
rust-bors[bot] merged 1 commit intoNov 5, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
This can't unwrap, e.g. `no_core` you're not guaranteed to have that lang item.
jieyouxu
force-pushed
the
jieyouxu/remove-stale-cfg-bootstrap
branch
from
November 5, 2026 12:27
aea2a34 to
b17c1a8
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit b17c1a8 with merge 2af19de... Workflow: https://github.com/rust-lang/rust/actions/runs/42040750754 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
… r=folkertdev c-variadic: remove stale `cfg(bootstrap)` comment This can't unwrap, e.g. under `no_core` you're not guaranteed to have that lang item. Noticed when grepping for `cfg(bootstrap)` when reviewing an unrelated PR. r? @folkertdev (or compiler)
Member
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #165510. |
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
…uwer Rollup of 8 pull requests Successful merges: - #165496 (c-variadic: remove stale `cfg(bootstrap)` comment) - #164716 (Lower UEFI targets through LLVM's *uefi triple) - #165497 (fix unsoundness when compiling `[diverging_const; _]`) - #165275 (Build TPDE with local Clang when available) - #165467 (Use `emit_ptr_va_arg` for `va_arg` on MSP430) - #165483 (compiletest: Fix the edition of minicore to the latest stable one) - #165498 (LoongArch: Fix direct-access-external-data test) - #165501 (rustdoc: Don't add a border on an empty `:target` element)
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 5, 2026
Rollup merge of #165496 - jieyouxu:jieyouxu/remove-stale-cfg-bootstrap, r=folkertdev c-variadic: remove stale `cfg(bootstrap)` comment This can't unwrap, e.g. under `no_core` you're not guaranteed to have that lang item. Noticed when grepping for `cfg(bootstrap)` when reviewing an unrelated PR. r? @folkertdev (or compiler)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can't unwrap, e.g. under
no_coreyou're not guaranteed to have that lang item.Noticed when grepping for
cfg(bootstrap)when reviewing an unrelated PR.r? @folkertdev (or compiler)