[WaffleLapkin]

Alternative to #124439 that I feel easier about.

Refactors how we handle x setup and adds a question about denying warnings.

r? @Kobzol

[rustbot]

Kobzol is not on the review rotation at the moment.
They may take a while to respond.

[WaffleLapkin]

This makes x setup library/etc be interactive. Is that a problem?

View changes since the review

[Kobzol]

I don't think so, other setup commands are already interactive, and I assume that it doesn't really make sense to use those commands non-interactively 🤔 If yes, people can just stuff yes into it.

[rust-log-analyzer]

The job test-aarch64-gnu-llvm-22-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

cargo:warning=Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-gnu-g++": No such file or directory (os error 2)


error: expect test failed
   --> snapshots/x_setup.snap

You can update all `expect!` tests by running:

    env UPDATE_EXPECT=1 cargo test

To update a single test, place the cursor on `expect` token and use `run` feature of rust-analyzer.

Expect:
----
---
source: src/bootstrap/src/core/builder/cli_paths/tests.rs
expression: setup
---
[Setup] setup::Profile
    targets: [aarch64-unknown-linux-gnu]
    - Set({compiler})
    - Set({dist})
    - Set({library})
    - Set({none})
    - Set({tools})
[Setup] setup::Hook
    targets: [aarch64-unknown-linux-gnu]
    - Set({hook})
[Setup] setup::Link
    targets: [aarch64-unknown-linux-gnu]
    - Set({link})
[Setup] setup::Editor
    targets: [aarch64-unknown-linux-gnu]
    - Set({editor})

----

Actual:
----
---
source: src/bootstrap/src/core/builder/cli_paths/tests.rs
expression: setup
---
[Setup] setup::bootstrap_toml::BootstrapToml
    targets: [aarch64-unknown-linux-gnu]
    - Set({compiler})
    - Set({dist})
    - Set({library})
    - Set({none})
    - Set({tools})
[Setup] setup::hook::Hook
    targets: [aarch64-unknown-linux-gnu]
    - Set({hook})
[Setup] setup::link::Link
    targets: [aarch64-unknown-linux-gnu]
    - Set({link})
[Setup] setup::editor::Editor
    targets: [aarch64-unknown-linux-gnu]
    - Set({editor})

----

Diff:
----
---
source: src/bootstrap/src/core/builder/cli_paths/tests.rs
expression: setup
---
[Setup] setup::Profilebootstrap_toml::BootstrapToml
    targets: [aarch64-unknown-linux-gnu]
    - Set({compiler})
    - Set({dist})
    - Set({library})
    - Set({none})
    - Set({tools})
[Setup] setup::hook::Hook
    targets: [aarch64-unknown-linux-gnu]
    - Set({hook})
[Setup] setup::link::Link
    targets: [aarch64-unknown-linux-gnu]
    - Set({link})
[Setup] setup::editor::Editor
    targets: [aarch64-unknown-linux-gnu]
    - Set({editor})

----

---- core::builder::cli_paths::tests::x_setup stdout end ----

[Kobzol]

Looks good! Left some comments. GitHub is not allowing me to comment inline atm, so:

I was a bit confused reading the "Rust CI fails when there are any warnings." sentence. The "forces you to rebuild" is a bit misleading, I think. The real problem is that it forces you to fix the warnings before you can get a working compiler build, right?

[Kobzol]

Could we just use raw strings (r#"..."#) here and in rust_section? 😆 It would be much more readable.