Repository navigation
Rollup of 7 pull requests - #165283
Closed
JonathanBrouwer wants to merge 15 commits into
Closed
Rollup of 7 pull requests#165283JonathanBrouwer wants to merge 15 commits into
JonathanBrouwer wants to merge 15 commits into
Conversation
This lint is similar to the existing `let_underscore_lock` lint, but applies to `DropGuard` instead of `MutexGuard` and similar types.
If a busy CI network or a Quirky EMUlator is used, then the OS default connection timeout may not be enough in order to successfully reach the remote device in time, leading to flaky test failures. As a first attempt to address the slight problem, this therefore proposes to extend the already-existing timeout configuration to the remaining performed connections. This way, all connections are effectively configured by the tool's dedicated environment variable or its default. In practice, it seems to have successfully fixed the issues we had. Signed-off-by: Paul Mabileau <[email protected]>
Verbose suggestions are much easier to read for people, at the cost of marginal additional vertical real estate in some cases.
```
error[E0423]: cannot find value `SomeStruct` in crate `remapped_dep`
--> $DIR/remap-path-prefix-reverse.rs:15:27
|
LL | let _ = remapped_dep::SomeStruct;
| ^^^^^^^^^^
|
::: remapped-aux/remapped_dep.rs:4:1
|
LL | pub struct SomeStruct {} // This line should be show as part of the error.
| --------------------- `remapped_dep::SomeStruct` defined here
|
= note: a struct named `remapped_dep::SomeStruct` exists in another namespace
help: use struct literal syntax instead
|
LL | let _ = remapped_dep::SomeStruct {};
| ++
```
instead of
```
error[E0423]: cannot find value `SomeStruct` in crate `remapped_dep`
--> $DIR/remap-path-prefix-reverse.rs:15:27
|
LL | let _ = remapped_dep::SomeStruct;
| --------------^^^^^^^^^^
| |
| help: use struct literal syntax instead: `remapped_dep::SomeStruct {}`
|
::: remapped-aux/remapped_dep.rs:4:1
|
LL | pub struct SomeStruct {} // This line should be show as part of the error.
| --------------------- `remapped_dep::SomeStruct` defined here
|
= note: a struct named `remapped_dep::SomeStruct` exists in another namespace
```
When encountering a tuple struct that can't be constructed because of private fields, do not suggest local binding typo, as the only valid case would be a local closure but during resolve we can't confirm that is the case.
Previously, creating an issue with this template would produce an issue with no labels.
…, r=Mark-Simulacrum lib: specialize vec extend_with specializes `Vec::extend_with` for `T: TrivialClone`, which in turn affects `Vec::resize`, `alloc::vec::from_elem`, and the `vec![]` macro. perf: https://rust.godbolt.org/z/8P5M3fP9e LLM's were not utilized for the making of this PR or the description.
…out, r=Mark-Simulacrum Chore(remote-test-client): Generalize the timeout to all connections If a busy CI network or a Quirky EMUlator is used, then the OS default connection timeout may not be enough in order to successfully reach the remote device in time, leading to flaky test failures. As a first attempt to address the slight problem, this therefore proposes to extend the already-existing timeout configuration to the remaining performed connections. This way, all connections are effectively configured by the tool's dedicated environment variable or its default. In practice, it seems to have successfully fixed the issues we had.
…rd, r=petrochenkov Add `let_underscore_drop_guard` lint. This lint is similar to the existing [`let_underscore_lock`](https://doc.rust-lang.org/rustc/lints/listing/deny-by-default.html#let-underscore-lock) lint, but applies to `DropGuard` instead of `MutexGuard` and similar types. It is deny-by-default, like `let_underscore_lock`. (Note that the related `let_underscore_drop` lint is allow-by-default.) Relevant discussion: [#t-libs > Linting &rust-lang#96;let _ = DropGuard::new(....);&rust-lang#96;](https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Linting.20.60let.20_.20.3D.20DropGuard.3A.3Anew.28.2E.2E.2E.2E.29.3B.60/with/631977543) Note that `DropGuard` is a newly stabilized type, currently in 1.100 beta, and will be on the 1.100 stable release on November 12. Tracking issue for `DropGuard`: rust-lang#144426
Refactor box downcasting methods We are doing this too often: ```rust let (raw, alloc) = Box::into_raw_with_allocator(this); Box::from_raw_in(raw.cast(), alloc) ``` So I factored it out into its own function. Also the downcasting methods for `dyn Any/Error + AutoTraits` are all doing the same thing, and can be implemented using the same generic function. The code transmuting `Box<dyn Error>` back to `Box<dyn Error + AutoTraits>` was also super dubious for no good reason (other than convenience)
…65, r=joboet Improve mem::take wording Closes rust-lang#165065 Updated to use “switch” instead of “replace”.
[small] Tweak suggestions in struct literal resolve errors When encountering a tuple struct that can't be constructed because of private fields, do not suggest local binding typo, as the only valid case would be a local closure but during resolve we can't confirm that is the case. Fix rust-lang#66067. Make incorrect struct literal syntax suggestion verbose. Verbose suggestions are much easier to read for people, at the cost of marginal additional vertical real estate in some cases. ``` error[E0423]: cannot find value `SomeStruct` in crate `remapped_dep` --> $DIR/remap-path-prefix-reverse.rs:15:27 | LL | let _ = remapped_dep::SomeStruct; | ^^^^^^^^^^ | ::: remapped-aux/remapped_dep.rs:4:1 | LL | pub struct SomeStruct {} // This line should be show as part of the error. | --------------------- `remapped_dep::SomeStruct` defined here | = note: a struct named `remapped_dep::SomeStruct` exists in another namespace help: use struct literal syntax instead | LL | let _ = remapped_dep::SomeStruct {}; | ++ ``` instead of ``` error[E0423]: cannot find value `SomeStruct` in crate `remapped_dep` --> $DIR/remap-path-prefix-reverse.rs:15:27 | LL | let _ = remapped_dep::SomeStruct; | --------------^^^^^^^^^^ | | | help: use struct literal syntax instead: `remapped_dep::SomeStruct {}` | ::: remapped-aux/remapped_dep.rs:4:1 | LL | pub struct SomeStruct {} // This line should be show as part of the error. | --------------------- `remapped_dep::SomeStruct` defined here | = note: a struct named `remapped_dep::SomeStruct` exists in another namespace ```
…ls, r=Kivooeo Fix FCW issue template labels Previously, creating an issue with this template would produce an issue with no labels.
rustbot
added
A-testsuite
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 1, 2026
Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for fecea62 failed: CI. Failed job:
|
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
Contributor
rust-bors
Bot
removed
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Nov 1, 2026
Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3 try-job: test-aarch64-msvc-2
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
PR #164414, which is a member of this rollup, was unapproved. This rollup was thus unapproved. |
rustbot
removed
the
S-waiting-on-author
rust-bors
Bot
added
the
S-waiting-on-author
Contributor
|
💔 Test for 7aed137 failed: CI. Failed job:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
let_underscore_drop_guardlint. #164414 (Addlet_underscore_drop_guardlint.)r? @ghost
Create a similar rollup