Repository navigation
Add regression tests for #164253 - #164910
hina-kura49 wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
|
Thanks for the pull request, and welcome! The Rust Project has assigned @camelid (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
With `-Znext-solver=globally`, the examples in the reported issue used
to ICE with "failed to resolve instance" during monomorphization.
They now fail with a normal error instead. The first example was
fixed by an earlier compiler change.
`recursion-issue-164253-1.rs` is the example from the issue
description. It should fail with "reached the recursion limit while
instantiating".
`recursion-issue-164253-2.rs` is a smaller example posted in a comment
on the issue. It should fail with E0275 ("overflow evaluating the
requirement").
Both tests run with the current and the next solver. They are
`build-fail` because the ICE happened during monomorphization, and use
`forbid-output: internal compiler error` so that the ICE cannot come
back unnoticed. `recursion_depth_exceeding_limit` is allowed because it
is unrelated to this issue and is planned to become an error.
c380b6a to
f6b4997
Compare
|
Hey, thanks for your PR!
Our LLM policy (linked in the bot comment above) prohibits using LLMs to write comments or messages. In this case, your PR description is quite long and a bit hard to follow (probably because of the LLM use). It should really be just a few sentences. Please rewrite the messages yourself and format the test code using rustfmt. Thanks! |
camelid
added
S-waiting-on-author
|
@camelid |
Closes #164253
This adds regression tests for the two examples in #164253. Both used to ICE with
-Znext-solver=globally("failed to resolve instance"). They no longer ICE on current nightly, so the issue can be closed once these tests are in, as suggested in the issue.