Repository navigation
triagebot: Delete the libs ad-hoc group - #164606
Conversation
To my understanding, this group was needed prior to the libs team refactor when we had people doing library reviews that weren't actually on T-libs. Since the refactor, everybody here is on T-libs so we should be able to use that default list for reviews. `set-team-rotation-mode` can be used by anybody who wants to opt out.
rustbot
added
A-meta
|
@Urgau does this make sense? We were a bit confused about why new libs team members weren't getting on the rotation automatically, which I believe this should resolve. |
|
That's our understanding as well (discussed on the libs private channel). I'll update our individual members if this looks reasonable |
|
Indeed this should be possible now. It would be good to check if all original members of the adhoc group are in t-libs (otherwise they would be removed from the rotation by this). |
I did check that, everybody is there now 👍 and I think we'd probably just add any users doing libs reviews to T-libs in the future |
|
Would one of you mind approving if this looks reasonable? |
|
@bors r+ rollup I'll go ahead and approve, I think we have the tools to apply this out of band and/or revert if needed. |
rust-bors
Bot
added
S-waiting-on-bors
Rollup of 5 pull requests Successful merges: - #164568 (Exclude MaybeDangling like types from SROA) - #163771 (update {Ipv4Addr,Ipv6Addr}::is_global to match IANA registries) - #164268 ([rustdoc] Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc) - #164581 (Revert "Remove indirection for `Expr` in `Body`") - #164606 (triagebot: Delete the libs ad-hoc group)
Rollup merge of #164606 - tgross35:triagebot-libs, r=Mark-Simulacrum triagebot: Delete the libs ad-hoc group To my understanding, this group was needed prior to the libs team refactor when we had people doing library reviews that weren't actually on T-libs. Since the refactor, everybody here is on T-libs so we should be able to use that default list for reviews. `set-team-rotation-mode` can be used by anybody who wants to opt out.
To my understanding, this group was needed prior to the libs team refactor when we had people doing library reviews that weren't actually on T-libs. Since the refactor, everybody here is on T-libs so we should be able to use that default list for reviews.
set-team-rotation-modecan be used by anybody who wants to opt out.r? @Urgau