[KevinA-cpu]

View all comments

• Add a note for unstable suggestions
• Only suggest intrinsics when the core_intrinsics feature is enabled

r? @JonathanBrouwer

Related:
Started from issue #78130
Created PR #161540 for regression tests
Then move to this PR for improvement points

[JonathanBrouwer]

@bors try jobs=x86_64-gnu-stable

[JonathanBrouwer]

Could you place the note below the help: consider importing this struct? That improves the reading order

View changes since the review

[KevinA-cpu]

I want to clarify @JonathanBrouwer, do you want to reorder so that the note is below the help universally, or do you only want this particular new note we're adding to be below the help?

Below is an example where a note above the help might be more useful:

= note: 'std::convert::TryFrom' is included in the prelude starting in Edition 2021
help: consider importing this trait

[JonathanBrouwer]

I mean I want the note to be under the help universally.
The idea being that we first tell the user "you might have meant x" then "by the way, x is unstable". If you start with "x is unstable" its not obvious why the compiler is telling us that until you read the next sentence

[KevinA-cpu]

Updated

[JonathanBrouwer]

The note is still above the help.

That is, I want

error[E0425]: cannot find type `BorrowedBuf` in this scope
  --> $DIR/import-suggestion-unstable-feature-note.rs:9:12
   |
LL |     let _: BorrowedBuf;
   |            ^^^^^^^^^^^ not found in this scope
   |
   = note: 'std::io::BorrowedBuf' is unstable, add `#![feature(core_io_borrowed_buf)]` to the crate attributes to enable
help: consider importing this struct
   |
LL + use std::io::BorrowedBuf;
   |

To change to (approximately)

error[E0425]: cannot find type `BorrowedBuf` in this scope
  --> $DIR/import-suggestion-unstable-feature-note.rs:9:12
   |
LL |     let _: BorrowedBuf;
   |            ^^^^^^^^^^^ not found in this scope
   |
help: consider importing this struct
   |
LL + use std::io::BorrowedBuf;
   |
note: 'std::io::BorrowedBuf' is unstable, add `#![feature(core_io_borrowed_buf)]` to the crate attributes to enable

[JonathanBrouwer]

I noticed you implemented this universally, for all suggestions. I intended to limit this to only this specific diagnostic, this seems like quite a big change for this

[KevinA-cpu]

Yep, I got confused by

I mean I want the note to be under the help universally.

I will revert most of the changes, LOL

[JonathanBrouwer]

Oh I'm sorry, the way I answered that is indeed confusing, I misunderstood your question. I meant for all places where this diagnostic is emitted

[KevinA-cpu]

So from my efforts and investigate, it looks like it won't be a small change to try and make the note of this diagnostics to be below the help.

The emitter in compiler/rustc_errors/src/annotate_snippet_emitter_writer.rs always prints every child (note/help added with err.note etc.) before every suggestion. So to achieve the order you're looking for it would require new mechanism and thus change alot of ui tests. (or making this help not a suggestion)

Unless, do you have any suggestions (pun intended)?

[JonathanBrouwer]

I'll take a look sometime in the next few days, thanks for trying!

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[rust-bors]

☀️ Try build successful (CI)
Build commit: c00b75b (c00b75bd88d2b929fd91c696b206b37c632003e0)
Base parent: 0dfb098 (0dfb098f3aeecbe38c2566ca090193280e7349e7)

[JonathanBrouwer]

@rustbot ready

[JonathanBrouwer]

Fyi I'm on holidays (at Eurorust) this week I'll get to any review next week

[KevinA-cpu]

@rustbot ready

[rustbot]

rustc_errors::annotate_snippet_emitter_writer was changed

cc @Muscraft

[rustbot]

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[JonathanBrouwer]

@rustbot ready