Skip to content

Variance checks unused type param - #153367

Closed
mro95 wants to merge 2 commits into
rust-lang:mainfrom
mro95:mro95/variance-unused-type-param
Closed

mro95 wants to merge 2 commits into
rust-lang:mainfrom
mro95:mro95/variance-unused-type-param

Conversation

@mro95

@mro95 mro95 commented Mar 3, 2026 •

Copy link
Copy Markdown

Fixes #152884

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 3, 2026
@theemathas theemathas added T-lang Relevant to the language team needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. needs-crater This change needs a crater run to check for possible breakage in the ecosystem. T-types Relevant to the types team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 4, 2026
@rust-bors

rust-bors Bot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #153416) made this pull request unmergeable. Please resolve the merge conflicts.

@lcnr lcnr added the I-types-nominated Nominated for discussion during a types team meeting. label Mar 24, 2026
@lcnr

lcnr commented Mar 24, 2026 •

Copy link
Copy Markdown
Contributor

sorry for not getting to this, started a discussion in https://rust-lang.zulipchat.com/#narrow/channel/326866-t-types.2Fnominated/topic/.23153367.3A.20Variance.20checks.20unused.20type.20param/with/581309933 as I don't have the capacity to push this through myself rn

@lcnr lcnr removed the I-types-nominated Nominated for discussion during a types team meeting. label Oct 1, 2026
@lcnr

lcnr commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

the rest of T-types also doesn't seem to have the capacity to take this on. Closing. Sorry 😬

@lcnr lcnr closed this Oct 1, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-crater This change needs a crater run to check for possible breakage in the ecosystem. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. T-lang Relevant to the language team T-types Relevant to the types team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unused generic in struct definition is allowed when used in invariant position

4 participants