Skip to content

Stabilize proc_macro_value feature - #151973

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:stabilize-proc_macro_value
Open

Stabilize proc_macro_value feature#151973
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:stabilize-proc_macro_value

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Feb 2, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Fixes #136652.

The feature implementation is complete: all string related values now have their _value method and proc_macro2 integration seems to be working as expected.

Integers are voluntarily left untouched as an equivalent API for them is much trickier to provide. I'll open an ACP once I come up with a design I'm happy with.

r? @Amanieu

@GuillaumeGomez GuillaumeGomez added the T-libs-api [DEPRECATED; DO NOT USE] label Feb 2, 2026
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2026
@jhpratt jhpratt added the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Feb 2, 2026
@Amanieu

Amanieu commented Mar 28, 2026

Copy link
Copy Markdown
Member

r? @dtolnay

@rustbot rustbot assigned dtolnay and unassigned Amanieu Mar 28, 2026
@Amanieu

Amanieu commented Mar 28, 2026

Copy link
Copy Markdown
Member

I'm not sure if we should be stabilizing this without at least a sketch for the the integer value API, but I'm not the best person to determine this since I haven't used the proc macro API much.

traviscross
traviscross reviewed May 31, 2026
View reviewed changes
Comment thread library/proc_macro/src/lib.rs Resolved
Comment thread library/proc_macro/src/lib.rs Resolved
Comment thread library/proc_macro/src/lib.rs Resolved
This was referenced Jun 2, 2026
Merged
Closed
@rust-bors

This comment has been minimized.

Sign in to view
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026
@jhpratt
Rollup merge of rust-lang#157338 - GuillaumeGomez:byte_character_valu…
62c1695 
…e, r=traviscross,Mark-Simulacrum

Make `Literal::byte_character_value` work with bytes as well

As noted in [this comment](rust-lang#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.

r? @traviscross
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 9, 2026
@jhpratt
Rollup merge of rust-lang#157338 - GuillaumeGomez:byte_character_valu…
46ce37e 
…e, r=traviscross,Mark-Simulacrum

Make `Literal::byte_character_value` work with bytes as well

As noted in [this comment](rust-lang#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.

r? @traviscross
rust-timer added a commit that referenced this pull request Jun 10, 2026
@rust-timer
Unrolled build for #157338
e602611 
Rollup merge of #157338 - GuillaumeGomez:byte_character_value, r=traviscross,Mark-Simulacrum

Make `Literal::byte_character_value` work with bytes as well

As noted in [this comment](#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.

r? @traviscross
pull Bot pushed a commit to Kokoro2336/rust-analyzer that referenced this pull request Jun 11, 2026
@jhpratt
Rollup merge of #157338 - GuillaumeGomez:byte_character_value, r=trav…
98cb773 
…iscross,Mark-Simulacrum

Make `Literal::byte_character_value` work with bytes as well

As noted in [this comment](rust-lang/rust#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.

r? @traviscross
@GuillaumeGomez
GuillaumeGomez force-pushed the stabilize-proc_macro_value branch from d96083f to 300da0f Compare June 15, 2026 13:39
@rustbot

rustbot commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez

GuillaumeGomez commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

Fixed merge conflict. Are there any concerns remaining or should we start an FCP?

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 15, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157935 - GuillaumeGomez:ConversionErrorKind…
12a2d3c 
…-non-exhaustive, r=traviscross,Mark-Simulacrum

Make `proc_macro::ConversionErrorKind` non exhaustive

Needed for rust-lang#151973.

r? @traviscross
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 18, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157935 - GuillaumeGomez:ConversionErrorKind…
3ecdd65 
…-non-exhaustive, r=traviscross,Mark-Simulacrum

Make `proc_macro::ConversionErrorKind` non exhaustive

Needed for rust-lang#151973.

r? @traviscross
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 18, 2026
@GuillaumeGomez
Rollup merge of rust-lang#157935 - GuillaumeGomez:ConversionErrorKind…
97e7f77 
…-non-exhaustive, r=traviscross,Mark-Simulacrum

Make `proc_macro::ConversionErrorKind` non exhaustive

Needed for rust-lang#151973.

r? @traviscross
rust-timer added a commit that referenced this pull request Jun 18, 2026
@rust-timer
Unrolled build for #157935
1101773 
Rollup merge of #157935 - GuillaumeGomez:ConversionErrorKind-non-exhaustive, r=traviscross,Mark-Simulacrum

Make `proc_macro::ConversionErrorKind` non exhaustive

Needed for #151973.

r? @traviscross
@GuillaumeGomez

GuillaumeGomez commented Jun 19, 2026

Copy link
Copy Markdown
Member Author

All suggestions were implemented. cc @traviscross

@GuillaumeGomez

GuillaumeGomez commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

ping @rust-lang/libs-api

ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
@jhpratt
Rollup merge of #157338 - GuillaumeGomez:byte_character_value, r=trav…
b3d3e60 
…iscross,Mark-Simulacrum

Make `Literal::byte_character_value` work with bytes as well

As noted in [this comment](rust-lang/rust#151973 (comment)), `byte_character_value` should work for bytes, so this PR fixes it.

r? @traviscross
@clarfonthey clarfonthey added T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-libs-api [DEPRECATED; DO NOT USE] labels Aug 12, 2026
@clarfonthey

clarfonthey commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@rustbot label:I-libs-nominated

@rustbot rustbot added the I-libs-nominated Nominated for discussion during a libs team meeting. label Aug 24, 2026
@clarfonthey

clarfonthey commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

r? libs

@rustbot rustbot assigned nia-e and unassigned dtolnay Aug 24, 2026
@nia-e

nia-e commented Aug 25, 2026

Copy link
Copy Markdown
Member

@rfcbot fcp merge libs

@rust-rfcbot

rust-rfcbot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@nia-e has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/libs-ping: FCP proposed for libs, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

@rust-rfcbot rust-rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. and removed needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Aug 25, 2026
@clarfonthey clarfonthey removed the I-libs-nominated Nominated for discussion during a libs team meeting. label Sep 13, 2026
@hanna-kruppe hanna-kruppe mentioned this pull request Nov 5, 2026
Open
2 of 3 tasks
programmerjake
programmerjake reviewed Nov 5, 2026
View reviewed changes
Comment thread library/proc_macro/src/lib.rs
#[stable(feature = "proc_macro_value", since = "CURRENT_RUSTC_VERSION")]
#[derive(Debug, PartialEq, Eq)]
#[non_exhaustive]
pub enum EscapeError {

@programmerjake programmerjake Nov 5, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a struct wrapping a private enum -- several of the existing enum variants would be immediately obsolete when in-progress changes are stabilized, e.g. NonAsciiCharInByte with https://github.com/rust-lang/rfcs/blob/3bdcd22feea6848a7920fa06d17ad4c6ada9db89/text/3349-mixed-utf8-literals.md

View changes since the review

programmerjake
programmerjake reviewed Nov 5, 2026
View reviewed changes
Comment thread library/proc_macro/src/lib.rs
/// literal.
#[unstable(feature = "proc_macro_value", issue = "136652")]
#[stable(feature = "proc_macro_value", since = "CURRENT_RUSTC_VERSION")]
pub fn cstr_value(&self) -> Result<Vec<u8>, ConversionErrorKind> {

@programmerjake programmerjake Nov 5, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not return CString?

View changes since the review

@GuillaumeGomez GuillaumeGomez Nov 6, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened #165550.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 6, 2026
Merged
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 7, 2026
@Zalathar
Rollup merge of rust-lang#165550 - GuillaumeGomez:proc-macro-literal-…
07d106d 
…api, r=programmerjake

Make `Literal::cstr_value` return a `CString`

Part of rust-lang#136652, suggested [here](rust-lang#151973 (comment)).

r? @programmerjake
rust-bors Bot pushed a commit that referenced this pull request Nov 7, 2026
@bors
Unrolled build for #165550 in rollup 165579
d20f60c 
Rollup merge of #165550 - GuillaumeGomez:proc-macro-literal-api, r=programmerjake

Make `Literal::cstr_value` return a `CString`

Part of #136652, suggested [here](#151973 (comment)).

r? @programmerjake
@rust-bors

rust-bors Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #165579) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@traviscross traviscross traviscross left review comments
@programmerjake programmerjake programmerjake left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@nia-e nia-e

Labels

disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking issue for proc_macro_value

10 participants

@GuillaumeGomez @Amanieu @rustbot @clarfonthey @nia-e @rust-rfcbot @traviscross @programmerjake @dtolnay @jhpratt