Repository navigation
Add support for // only-cfg-target-has-atomic to compiletest #87377
Description
Right now, you have to specify the platforms and architectures you want by hand, which makes it easy to leave them out or include platforms you shouldn't. It would be nice to automate this - maybe with rustc --print cfg?
Originally posted by @wesleywiser in #84039 (comment)
Metadata
Metadata
Assignees
Labels
Area: The compiletest test runnerArea: The testsuite used to check the correctness of rustcCategory: A feature request, i.e: not implemented / a PR.Call for participation: Medium difficulty. Experience needed to fix: Intermediate.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Activity
RalfJung commentedon Jul 24, 2021
Can't you use
#[cfg(target_has_atomic)]in the test to basically stub it out?jyn514 commentedon Jul 24, 2021
@RalfJung no, because that will cause the test to fail (because it's missing the errors rustc would normally emit).
RalfJung commentedon Jul 24, 2021
Ah, good point -- thanks!
jieyouxu commentedon Oct 17, 2024
compiletest triage: this should probably use the
needs-*machinery for capability requirements, i.e.//@ needs-atomicor a better name.kei519 commentedon Nov 13, 2024
I want to try this as my first contribution. Is it ok?
@rustbot claim
Add new test directive `needs-atomic` to support rust-lang#87377
Add new test directive `needs-atomic` to support rust-lang#87377
jieyouxu commentedon Nov 20, 2024
Apparently this is a bit more tricky than I expected initially.
@rustbot label -E-easy +E-medium
Add new test directive `needs-target-has-atomic` to support rust-lang…
Add new test directive `needs-target-has-atomic` to support rust-lang…
Add `needs-target-has-atomic` directive
Rollup merge of rust-lang#133736 - jieyouxu:needs-target-has-atomic, …
Unrolled build for rust-lang#133736
jieyouxu commentedon Dec 19, 2024
Implemented in #133736.