Repository navigation
Inert attributes in $expr nonterminals are sometimes duplicated #86055
Description
Reproducer:
macro mac($expr:expr) {
print_bang!($expr);
}
fn main() {
mac!(#[allow(warnings)] 0);
}where print_bang is a proc macro from https://github.com/rust-lang/rust/blob/master/src/test/ui/proc-macro/auxiliary/test-macros.rs
The result looks like this:
PRINT-BANG INPUT (DISPLAY): #[allow(warnings)] 0
PRINT-BANG RE-COLLECTED (DISPLAY): #[allow(warnings)] #[allow(warnings)] 0
The issue can be reproduced after merging #84995, before that PR the example ICEs.
Activity
bvanjoi commentedon Jun 5, 2023
It appears that
parse_expr_force_collecthas caused duplication of theExprbetween the attrsandtokens. Can we remove these duplicated attrsby comparing tokensand attrs?Change how `parse_expr_force_collect` works.
Auto merge of rust-lang#126678 - nnethercote:fix-duplicated-attrs-on-…
Auto merge of rust-lang#126678 - nnethercote:fix-duplicated-attrs-on-…