Skip to content

clang-sys 0.29.3 fails to build on nightly #84162

Closed

Description

@Nemo157

I tried building clang-sys 0.29.3 with feature runtime on the latest nightly.

I expected to see this happen: it builds successfully.

Instead, this happened:

> cargo +nightly build --features runtime |& head -n 20
   Compiling clang-sys v0.29.3 (/tmp/tmp.EH8ss9nTlb/clang-sys-0.29.3)
error[E0642]: patterns aren't allowed in methods without bodies
    --> src/lib.rs:1660:39
     |
1660 |     pub fn clang_CXCursorSet_contains(set: CXCursorSet, cursor: CXCursor) -> c_uint;
     |                                       ^^^
     |
help: give this argument a name or use an underscore to ignore it
     |
1660 |     pub fn clang_CXCursorSet_contains(_: CXCursorSet, cursor: CXCursor) -> c_uint;
     |                                       ^

error[E0642]: patterns aren't allowed in methods without bodies
    --> src/lib.rs:1660:57
     |
1660 |     pub fn clang_CXCursorSet_contains(set: CXCursorSet, cursor: CXCursor) -> c_uint;
     |                                                         ^^^^^^
     |
help: give this argument a name or use an underscore to ignore it
     |

Meta[

rustc --version --verbose:

rustc 1.53.0-nightly (d0695c908 2021-04-12)
binary: rustc
commit-hash: d0695c9081b16077d0aed368bccaf437d77ff497
commit-date: 2021-04-12
host: x86_64-unknown-linux-gnu
release: 1.53.0-nightly
LLVM version: 12.0.0

Activity

  1. added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Apr 13, 2021
  2. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Apr 13, 2021
  3. Nemo157 commented on Apr 13, 2021

    @Nemo157
    ContributorAuthor

    First regressed in rustc 1.53.0-nightly (a86612456 2021-04-11).

  4. Aaron1011 commented on Apr 13, 2021

    @Aaron1011
    Contributor

    Will be fixed by #84130

  5. SimonSapin commented on Apr 14, 2021

    @SimonSapin
    Contributor

    This affects Servo too, through rust-bindgen:

    searched nightlies: from nightly-2021-04-10 to nightly-2021-04-12
    regressed nightly: nightly-2021-04-12
    searched commits: from a836d9b to a866124
    regressed commit: ba6275b

    bisected with cargo-bisect-rustc v0.6.0

    Host triple: x86_64-unknown-linux-gnu
    Reproduce with:

    cargo bisect-rustc -- check --features runtime 
  6. apiraino commented on Apr 14, 2021

    @apiraino
    Contributor

    Assigning P-critical for its impact, as discussed as part of the Prioritization Working Group procedure and removing I-prioritize.

    @rustbot label -I-prioritize +P-critical

  7. added and removed
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    on Apr 14, 2021
  8. pnkfelix commented on Apr 14, 2021

    @pnkfelix
    Contributor

    For the record, according to the bisection performed by @SimonSapin above, this was injected by PR #82608. (But as @Aaron1011 noted above, it will be fixed by PR #84130.)

  9. added this to the 1.53.0 milestone on Apr 14, 2021
  10. added a commit that references this issue on Apr 14, 2021
  11. added a commit that references this issue on Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: This is a bug.P-criticalCritical priorityT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions