Safe code (ui/issues/issue-69225-SCEVAddExpr-wrap-flag.rs) miscompiles under llvm9 + codegen-units=1 #81946

Activity

1. jonas-schievink

   added

   A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.

   C-bugCategory: This is a bug.Category: This is a bug.

   I-unsoundIssue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/SoundnessIssue: A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   on Feb 10, 2021
2. rustbot

   added

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Feb 10, 2021
3. jonas-schievink

   added

   regression-untriagedUntriaged performance or correctness regression.Untriaged performance or correctness regression.

   on Feb 10, 2021
4. Stupremee commented on Feb 10, 2021

   

   Stupremee

   on Feb 10, 2021

   Contributor

   More actions

   Assigning P-medium as discussed as part of the Prioritization Working Group procedure and removing I-prioritize.
5. Stupremee

   added

   P-mediumMedium priorityMedium priority

   and removed

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on Feb 10, 2021
6. nagisa commented on Feb 20, 2021

   

   nagisa

   on Feb 20, 2021

   Last edited by nagisa

   Member

   More actions

   I believe we use unpatched/upstream LLVM in for the llvm-9 CI jobs, which would make this technically a not-a-rustc-issue, given that the original fix relied on patching LLVM (10 &later).

   Conceptually it'd be upto the distribution maintainers to apply corresponding patches to the LLVM they ship.
7. nikic commented on Feb 20, 2021

   

   nikic

   on Feb 20, 2021

   Contributor

   More actions

   Right, I don't think there's anything we can really do here, as it's a bug in external LLVM. I think simply adding a min-llvm-version to the test would be fine.
8. Dylan-DPC-zz

   added a commit that references this issue on Mar 27, 2021

   Rollup merge of rust-lang#81942 - the8472:reduce-ui-test-threads, r=M…

   ...

   This issue will close once commit a9dac65 is merged into the 'master' branch.

   a9dac65
9. Dylan-DPC-zz

   added a commit that references this issue on Apr 4, 2021

   Rollup merge of rust-lang#81942 - the8472:reduce-ui-test-threads, r=M…

   ...

   This issue will close once commit e3e915c is merged into the 'master' branch.

   e3e915c
10. bors

    closed this as completedin da0b9b6on Apr 9, 2021