Skip to content

Spotlight shows traits with generic impls that do not apply to the specific type #74417

Open

Description

@Manishearth

In both these cases, the mutability or the generic parameter is not dealt with when showing spotlight impls:

image
image

#74370 (comment)

We should do something similar to what we do for auto traits and blanket impls.

Activity

  1. added
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    on Jul 16, 2020
  2. added
    C-bugCategory: This is a bug.
    A-rustdoc-uiArea: Rustdoc UI (generated HTML)
    on Aug 8, 2025
  3. added
    T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
    on Aug 8, 2025
  4. added
    E-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.
    E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc
    on Aug 8, 2025
  5. fmease commented on Aug 8, 2025

    @fmease
    Member

    Seems to be fixed (the Box<str> no longer has any "notable trait" spotlight & the "notable trait" spotlight for &[u8] now only contains the Read impl).

    Not sure which PR has fixed it (needs success bisection). Tentatively marking E-needs-test but we likely already have sufficient test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-uiArea: Rustdoc UI (generated HTML)A-trait-systemArea: Trait systemC-bugCategory: This is a bug.E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcE-needs-testCall for participation: An issue has been fixed and does not reproduce, but no test has been added.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions