Skip to content

split up rustc_middle/mir/mod.rs #73723

New issue
New issue
Closed
#73776
Closed
split up rustc_middle/mir/mod.rs#73723
#73776
Assignees
rustbot
Labels
A-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@oli-obk
oli-obk
opened on Jun 25, 2020

#73513 moved the file to over 3k LOC, but I didn't fix it there and instead just annotated the file so tidy ignores it. We should probably split the mir types into separate submodules by the way they are used in MIR. I think we can start by pulling out e.g. terminators and all their sub-types to a terminator submodule

This issue has been assigned to @aszenz via this comment.

Activity

  1. oli-obk
    added
    E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
    C-cleanupCategory: PRs that clean code up or issues documenting cleanup.
    on Jun 25, 2020
  2. jonas-schievink
    added
    A-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    on Jun 25, 2020

  3. aszenz commented on Jun 26, 2020

    @aszenz
    aszenz
    on Jun 26, 2020
    Contributor

    @rustbot claim
    Will be interested in picking this up

  4. rustbot
    assigned
    rustbot
    and unassigned
    rustbot
    on Jun 26, 2020
  5. Manishearth
    added 2 commits that reference this issue on Jul 1, 2020

    Rollup merge of rust-lang#73776 - aszenz:refactor_mir_module, r=wesle…

    978953e

    Rollup merge of rust-lang#73776 - aszenz:refactor_mir_module, r=wesle…

    d6bee55
  6. bors
    closed this as completedin d6bee55on Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlC-cleanupCategory: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions