-Zvalidate-mir: check that all referenced locals exist

When encountering a Local, there must be a corresponding LocalDecl in the MIR body. If there isn't, later passes can panic due to indexing out of bounds of the LocalDecl array. The validation pass could detect this problem earlier.

Instructions:

Extend the validation pass in src/librustc_mir/transform/validate.rs by implementing visit_local for the TypeChecker MIR visitor:

rust/src/librustc_mir/transform/validate.rs

Line 88 in 4fb54ed

impl<'a, 'tcx> Visitor<'tcx> for TypeChecker<'a, 'tcx> {

The Visitor trait is documented here.

The method should check that the local exists in self.body.local_decls, and fail with a descriptive error message if not (by calling self.fail, not by panicking directly).

@rustbot

@rustbot claim

@yerke

@yerke FYI, the validation pass currently fails on even libcore until #73175 is merged, so you need to either wait for that, or cherry-pick some commits from there to get it to work.

You can test your changes by running RUSTFLAGS_NOT_BOOTSTRAP="-Zvalidate-mir" ./x.py test --stage=1 src/test/ui (the validator only runs on very little code by default, -Zvalidate-mir turns it on for everything).

@jonas-schievink

@jonas-schievink I wanted to double check, running RUSTFLAGS_NOT_BOOTSTRAP="-Zvalidate-mir" ./x.py test --stage=1 src/test/ui should fail when I run it, right? It actually passed for me after I merged in your branch from #73359.
I wonder if I should try clean and build stage 1 again. :\

It should pass with #73359 applied, but fail on current master.

@jonas-schievink

@jonas-schievink So your PR fixes this issue (#73356) as well?

Ah, no, this issue is just about adding additional validation. It shouldn't actually detect any locals that don't exist. So the command should work both before and after implementing this. If it fails after implementing this, something else is going on that we should look into.

@yerke

@yerke are you still working on this?

No, sorry. Didn’t have time for it. Go ahead.

@rustbot

@rustbot release-assignment

Would like to work on this, but it seems there is another check, not on the declaration like this one, but on the memory liveness. This should cover the case that the local is not declared (I think), or would it not?

rust/compiler/rustc_mir/src/transform/validate.rs

Lines 187 to 192 in 1773f60

    
           // Uses of locals must occur while the local's storage is allocated. 
        
           self.storage_liveness.seek_after_primary_effect(location); 
        
           let locals_with_storage = self.storage_liveness.get(); 
        
           if !locals_with_storage.contains(*local) { 
        
               self.fail(location, format!("use of local {:?}, which has no storage here", local)); 
        
           }

Navigation Menu

Repository navigation

-Zvalidate-mir: check that all referenced locals exist #73356

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Uses of locals must occur while the local's storage is allocated.
	self.storage_liveness.seek_after_primary_effect(location);
	let locals_with_storage = self.storage_liveness.get();
	if !locals_with_storage.contains(*local) {
	self.fail(location, format!("use of local {:?}, which has no storage here", local));
	}

-Zvalidate-mir: check that all referenced locals exist #73356

Description

Activity

jonas-schievink commented on Jun 14, 2020

yerke commented on Jun 14, 2020

jonas-schievink commented on Jun 14, 2020

yerke commented on Jun 15, 2020

jonas-schievink commented on Jun 15, 2020

yerke commented on Jun 15, 2020

jonas-schievink commented on Jun 15, 2020

pitaj commented on Oct 15, 2020

yerke commented on Oct 15, 2020

jonas-schievink commented on Nov 7, 2020

natsukagami commented on Nov 8, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions