Regression of #53738: spurious single_use_lifetimes warning

Issue #53738 seems to have regressed.

I tried this code:

#[deny(single_use_lifetimes)]

#[derive(Eq)]
struct Foo<'a, T> {
    /// a reference to the underlying secret data that will be derefed
    pub data: &'a mut T,
}

I expected to see this happen: No warning should be produced.

Instead, this happened:

error: lifetime parameter `'a` only used once
 --> src/lib.rs:4:12
  |
3 | #[derive(Eq)]
  |          -- ...is used only here
4 | struct Foo<'a, T> {
  |            ^^ this lifetime...
  |
note: lint level defined here
 --> src/lib.rs:1:8
  |
1 | #[deny(single_use_lifetimes)]
  |        ^^^^^^^^^^^^^^^^^^^^

Meta

rustc --version --verbose:

rustc 1.42.0 (b8cedc004 2020-03-09)
binary: rustc
commit-hash: b8cedc00407a4c56a3bda1ed605c6fc166655447
commit-date: 2020-03-09
host: x86_64-apple-darwin
release: 1.42.0
LLVM version: 9.0

From what I can tell, the Eq case might have never worked, since Debug still doesn't warn (so the linked issue specifically maybe didn't regress, only a closely related example incorrectly warns). This needs confirmation though.

It also fails in 1.40 and 1.41.

It gets a different error in 1.39, with Eq complaining that PartialEq is not implemented, but if you add that then it does compile successfully.

@rustbot

@rustbot ping cleanup

bisect-rustc:

searched nightlies: from nightly-2019-09-01 to nightly-2020-03-10
regressed nightly: nightly-2019-10-28
searched commits: from fae75cd to 95f437b
regressed commit: b7176b4
source code: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=4bd9c10c79f908d449f607e5ce69bfa7

#[deny(single_use_lifetimes)]
#[derive(Eq)]
struct Foo<'a, T> {
    _y: &'a mut T,
}
impl<T> PartialEq for Foo<'_, T> {
    fn eq(&self, _x: &Self) -> bool {
        true
    }
}

Builds without errors as of rustc 1.39.0 and earlier (tested on godbolt)

Error

COLLAPSIBLE ERROR STACKTRACE

error: lifetime parameter `'a` only used once
 --> src/main.rs:4:12
  |
3 | #[derive(Eq)]
  |          -- ...is used only here
4 | struct Foo<'a, T> {
  |            ^^ this lifetime...
  |
note: the lint level is defined here
 --> src/main.rs:1:8
  |
1 | #[deny(single_use_lifetimes)]
  |        ^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

error: could not compile `bisectit`.

To learn more, run the command again with --verbose.

@pnkfelix

cc @pnkfelix , is it a good idea to assign this one to you Felix? regressed here #65519

@rustbot

@rustbot modify labels: -E-needs-bisection

Auto merge of rust-lang#96833 - cjgillot:ast-lifetimes-single, r=petr…

@dylni

@dylni points out this is not actually fixed: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=3dcd3a8a7f8b85cc732d738bf6e57dc2
cc @cjgillot

Rollup merge of rust-lang#103089 - cjgillot:automatic-structural-eq, …

Navigation Menu

Repository navigation

Regression of #53738: spurious single_use_lifetimes warning #69952

Meta

2 remaining items

Error

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Regression of #53738: spurious single_use_lifetimes warning #69952

Description

Meta

Activity

jonas-schievink commented on Mar 12, 2020

cuviper commented on Mar 12, 2020

spastorino commented on Mar 18, 2020

2 remaining items

chrissimpkins commented on Mar 18, 2020

Error

spastorino commented on Mar 20, 2020

LeSeulArtichaut commented on Mar 20, 2020

jyn514 commented on Jun 15, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions