1.39 error messages don't properly truncate, making autogenerated files (e.g. bindgen) spam the terminal #66229

Activity

1. q66

   changed the title [-]1.39 error messages dump seemingly entire source file where the affected line should be[/-] [+]1.39 error messages don't properly truncate, making autogenerated files (e.g. bindgen) spam the terminal[/+] on Nov 8, 2019
2. q66 commented on Nov 8, 2019

   

   q66

   on Nov 8, 2019

   Author

   More actions

   Actually, the source file appears to be one line. It's generated by rust-bindgen.
3. q66 commented on Nov 8, 2019

   

   q66

   on Nov 8, 2019

   Author

   More actions

   Here's the generated file from firefox: https://gist.githubusercontent.com/q66/ac25123ed168f61e2972af0bbc90fff0/raw/229094c3e8dfda7382eec22563d08538eaf83c03/gistfile1.txt
4. estebank commented on Nov 8, 2019

   

   estebank

   on Nov 8, 2019

   Contributor

   More actions

   #63402 implements the feature, but it needs to be integrated with cargo.
5. estebank

   added

   C-feature-requestCategory: A feature request, i.e: not implemented / a PR.Category: A feature request, i.e: not implemented / a PR.

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lints

   on Nov 8, 2019
6. est31 commented on Nov 9, 2019

   

   est31

   on Nov 9, 2019

   Member

   More actions

   See also the bindgen bug: rust-lang/rust-bindgen#1600

   I've added some pretty-printing code to my own project: RustAudio/deepspeech-rs@3323b0e

   Optimally it would live in bindgen though. Want to port it to bindgen, @q66 ?
7. q66 commented on Nov 9, 2019

   

   q66

   on Nov 9, 2019

   Author

   More actions

   no thanks, i have enough of my own work and prefer to touch this kinda stuff as little as possible. For now, I took patches from Gentoo to fix compilation of firefox/thunderbird (and adapted it for other stuff so that e.g. icecat can also build), which seems to work ok.
8. estebank commented on Jun 29, 2023

   

   estebank

   on Jun 29, 2023

   Contributor

   More actions

   I believe all of the work necessary here has been completed. Extremely long types in messages are now truncated and written to disk, and cargo passes through the terminal's width to rustc to truncate the code window in diagnostics.
9. estebank

   closed this as completedon Jun 29, 2023