Skip to content

compiletest: //~ ERROR should be interpreted as applying to all revisions #56279

Closed

Description

@pnkfelix

Spawned off of https://github.com/rust-lang/rust/pull/56244/files#r236635792

Right now, you have to write explicit //[rev]~ ERROR annotations for each revision rev in a given test. This is true even when all of the revisions can use identical annotations.

We should change compiletest so that occurrences of //~ ERROR are still parsed and are treated as synonymous for a copy of that same annotation for every revision in the // revisions: set.

Activity

  1. oli-obk commented on Nov 27, 2018

    @oli-obk
    Contributor

    In some situations it would also have been nice to be able to specify a set of revisions like //[revA revB]~ ERROR.

  2. added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    on Jan 11, 2019
  3. tmiasko commented on Feb 1, 2022

    @tmiasko
    Contributor

    Since #66524 //~ ERROR applies to all revisions, and //[A,B]~ ERROR to revisions A and B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-testsuiteArea: The testsuite used to check the correctness of rustc

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions