Cargo doc regression in crates that include #![deny(unused_imports)]

#![deny(unused_imports)]

use std::fs::File;

pub fn f() {
    let _: File;
}

cargo doc of the above lib.rs works up through cargo +nightly-2018-06-17 doc. As of cargo +nightly-2018-06-18 doc it fails with:

$ cargo +nightly-2018-06-18 doc
 Documenting unused-imports v0.0.0
error: unused import: `std::fs::File`
 --> src/lib.rs:3:5
  |
3 | use std::fs::File;
  |     ^^^^^^^^^^^^^
  |
note: lint level defined here
 --> src/lib.rs:1:9
  |
1 | #![deny(unused_imports)]
  |         ^^^^^^^^^^^^^^

error: Compilation failed, aborting rustdoc

error: Could not document `unused-imports`.

@QuietMisdreavus

That commit range: ae46aef...86a8f1a. Mentioning @QuietMisdreavus and @GuillaumeGomez who were touching librustdoc in that range and @petrochenkov who reviewed #51425.

The problem is a bit complex (to say the least)...

The problem was the introduction of the intra_doc_links_resolution_failure lint, which caused rustdoc to stop capping lints:

rust/src/librustdoc/core.rs

Line 216 in f790780

lint_cap: Some(lint::Forbid),

The sample in this issue (and the regression in winapi in #51689) both explicitly deny the lint, despite us allowing it in rustdoc ahead of time. We need a way to disable this lint (and potentially any others that are affected by everybody-loops?) when rustdoc is running. Alternately, some kind of "porous lint cap" that still lets us fire the intra-doc-links lint? Is that possible with the current system?

It requires investigation but I think we can.

unused_extern_crates causes a similar problem (see marshallpierce/rust-base64#64). Same root cause, or should I open a separate issue?

No, it's the same source. I know what the problem is, just need to fix it when I have time.

Only test nightly for now

Auto merge of #51956 - GuillaumeGomez:shutdown-doc-lints, r=oli-obk

I don't think we can consider this fixed yet. I get the impression from #51956 that the only lints that rustdoc is supposed to emit are missing_docs and intra_link_resolution_failure but some other lints like the following still trigger:

#![deny(non_upper_case_globals)]

pub const foo: u8 = 0;

error: constant `foo` should have an upper case name such as `FOO`
 --> a.rs:3:1
  |
3 | pub const foo: u8 = 0;
  | ^^^^^^^^^^^^^^^^^^^^^^
  |
note: lint level defined here
 --> a.rs:1:9
  |
1 | #![deny(non_upper_case_globals)]
  |         ^^^^^^^^^^^^^^^^^^^^^^

error: Compilation failed, aborting rustdoc

On 1.27 stable that would document without any issues.

Auto merge of #52796 - ollie27:rustdoc_beta_lints, r=QuietMisdreavus

Navigation Menu

Repository navigation

Cargo doc regression in crates that include #![deny(unused_imports)] #51661

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Cargo doc regression in crates that include #![deny(unused_imports)] #51661

Description

Activity

dtolnay commented on Jun 20, 2018

GuillaumeGomez commented on Jun 20, 2018

QuietMisdreavus commented on Jun 21, 2018

GuillaumeGomez commented on Jun 21, 2018

marshallpierce commented on Jun 25, 2018

GuillaumeGomez commented on Jun 25, 2018

ollie27 commented on Jul 21, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions