Applicability-ify suggestions #50723

Activity

1. bors

   added a commit that references this issue on May 28, 2018

   Auto merge of #50724 - zackmdavis:applicability_rush, r=Manishearth

   ...

   16cd84e
2. killercup

   added

   A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lints

   on Jun 22, 2018
3. zackmdavis

   added 3 commits that reference this issue on Aug 2, 2018

   add rust-lang/rust#50723 as an easy-level call for participation

   df8e98a
4. 6 remaining items

   Load more

5. estebank commented on Aug 17, 2018

   

   estebank

   on Aug 17, 2018

   Contributor

   More actions

   @ekse I believe it is possible, but it is a bad idea because we prefer to keep the diffs as small as possible. Unless you're actively touching the code, style only changes are slightly frowned upon. My personal rule of thumb is that if it's only affecting a few lines it's fine, if it's affecting the entire file it's not. Anything in between is a grey area that will depend on the reviewer. Keep in mind that the more extensive the diffs are, the more likely it is they will have/cause merge conflicts with other PRs.
6. GuillaumeGomez

   added a commit that references this issue on Aug 22, 2018

   Rollup merge of rust-lang#53504 - ekse:suggestions-applicability-2, r…

   ...

   4fa4bb5
7. kennytm

   added a commit that references this issue on Aug 28, 2018

   Rollup merge of rust-lang#53655 - jcpst:with_applicability, r=estebank

   ...

   13179e2
8. Mark-Simulacrum

   added a commit that references this issue on Aug 28, 2018

   Rollup merge of rust-lang#53655 - jcpst:with_applicability, r=estebank

   ...

   0a0157e
9. emilyalbini

   added 3 commits that reference this issue on Aug 29, 2018

   Rollup merge of rust-lang#53655 - jcpst:with_applicability, r=estebank

   ...

   bcd6880

   Rollup merge of rust-lang#53655 - jcpst:with_applicability, r=estebank

   ...

   bb7a4ee

   Rollup merge of rust-lang#53655 - jcpst:with_applicability, r=estebank

   ...

   1535075
10. Manishearth commented on Sep 13, 2018

    

    Manishearth

    on Sep 13, 2018

    Member

    More actions

    Btw, I'm willing to mentor folks in doing this!
11. kennytm

    added a commit that references this issue on Sep 21, 2018

    Rollup merge of rust-lang#54412 - jcpst:replace_span_suggestion, r=es…

    ...

    fa6c16e
12. emilyalbini

    added a commit that references this issue on Sep 22, 2018

    Rollup merge of rust-lang#54412 - jcpst:replace_span_suggestion, r=es…

    ...

    394d687
13. XAMPPRocky

    added

    T-dev-toolsRelevant to the dev-tools subteam, which will review and decide on the PR/issue.Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCCategory: An issue tracking the progress of sth. like the implementation of an RFC

    E-mentorCall for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

    on Oct 2, 2018
14. Centril

    added a commit that references this issue on Jan 19, 2019

    Rollup merge of rust-lang#57699 - euclio:applicability-ify, r=petroch…

    ...

    This issue will close once commit e78bde4 is merged into the 'master' branch.

    e78bde4
15. bors

    closed this as completedin #57699on Jan 19, 2019