Skip to content

run-make wasm tests cannot be run #50711

New issue
New issue
Closed
Closed
run-make wasm tests cannot be run#50711

Description

@ehuss
ehuss
opened on May 13, 2018

I am unable to run the wasm tests in src/test/run-make. It looks like the wasm32-unknown Travis image is no longer running them, either. Reverting some of the changes in #50000 brings them back (but causes the cross-lang-lto test to fail).

I'm not very familiar with the bootstrap code, so I'm uncertain how this should be fixed.

cc @alexcrichton @michaelwoerister

Activity

  1. alexcrichton commented on May 14, 2018

    @alexcrichton
    alexcrichton
    on May 14, 2018
    Member

    Oh oops, sorry I should have caught this in review!

    I think the fix is:

    • Move cross-lang-lto from run-make to run-make-fulldeps
    • Change the RunMake test suite back to default_test! from its current host_test!

    @ehuss or @michaelwoerister, would y'all be able to submit a PR with that?

  2. ehuss commented on May 15, 2018

    @ehuss
    ehuss
    on May 15, 2018
    ContributorAuthor

    I can give it a shot.

  3. ehuss
    added a commit that references this issue on May 15, 2018

    Fix run-make wasm tests

    a90a963
  4. bors
    closed this as completedin #50787on May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions