Hygiene affected when using multiple derive

Hi.
I have a proc-macro that generates a macro_rules!.
When I only do:

#[derive(MyCustomDerive)]
struct MyStruct {
}

I can use the generated macro.

However, if I add another custom derive like in:

#[derive(Serialize, MyCustomDerive)]
struct MyStruct {
}

I cannot use the macro anymore…
I get the error:

cannot find macro `my_macro!` in this scope

Strangely, if I do:

#[derive(MyCustomDerive, Serialize)]
struct MyStruct {
}

Putting the serde custom derive after mine fix the issue.
I don't know if it is related to serde or just a bug with multiple custom derives.
Thanks to fix this issue.

@dtolnay

@dtolnay Any info about this?

I was able to reproduce this but don't have an explanation.

#[macro_use]
extern crate repro;

#[macro_use]
extern crate serde_derive;

#[derive(Serialize, MyCustomDerive)]
struct MyStruct;

my_macro!();

fn main() {}

extern crate proc_macro;
use proc_macro::TokenStream;

#[proc_macro_derive(MyCustomDerive)]
pub fn f(_input: TokenStream) -> TokenStream {
    "
        macro_rules! my_macro {
            () => {}
        }
    ".parse().unwrap()
}

Triage: I see no strong indication to believe this is a bug in rustc, it seems more likely to be caused by serde, in which case it should be reported there, so let's close this issue. Of course feel free to reopen if it can be demonstrated that this can be reproduced without involving serde.

This was a rustc bug. It was fixed in Rust 1.39 by #63667.

Navigation Menu

Repository navigation

Hygiene affected when using multiple derive #47346

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Hygiene affected when using multiple derive #47346

Description

Activity

antoyo commented on Jan 30, 2018

dtolnay commented on Jan 30, 2018

Enselic commented on Sep 28, 2023

dtolnay commented on Sep 28, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions