Skip to content

CI: tests/mir-opt: 64bit-panic-abort is seemingly not tested #154607

New issue
New issue
Open
Open
CI: tests/mir-opt: 64bit-panic-abort is seemingly not tested#154607
Assignees
jieyouxu
Labels
A-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Description

@GrigorenkoPV
GrigorenkoPV
opened on Mar 30, 2026

#154004 moved core::ptr::Alignment to core::mem, but seems to have missed updating some of the mir-opt tests, which were fixed #154577.

Curious, why does this test pass against main after the rename? 🤔

But still, this PR only changes the diff, not the rs file. So, it seems like 64bit-panic-abort mir-opt is simply not checked at all by CI.

Originally posted by @RalfJung in #154577 (comment)

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Mar 30, 2026
  2. RalfJung
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    A-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)
    on Mar 30, 2026

  3. RalfJung commented on Mar 30, 2026

    @RalfJung
    RalfJung
    on Mar 30, 2026
    Member

    #154004 moved core::ptr::Alignment to core::mem, but seems to have missed updating some of the mir-opt tests,

    Specifically, some of the diff files were no updated. (The rs files were all fine.)
    And, notably, bors accepted the PR anyway. That shouldn't have happened.

  4. jieyouxu
    self-assigned this
    on Mar 31, 2026
  5. jieyouxu
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
    C-bugCategory: This is a bug.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Mar 31, 2026

  6. RalfJung commented on Jul 29, 2026

    @RalfJung
    RalfJung
    on Jul 29, 2026
    Member

    This is still broken, in fact the mir-opt reference files currently in the tree are just wrong.
    #t-compiler > Blessing mir-opt on a clean checkout produces a diff @ 💬

    @rust-lang/infra any idea where these should be tested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

A-test-infraArea: test infrastructure (may span bootstrap/compiletest/more)A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions