Repository navigation
Closed
Labels
C-bugCategory: This is a bug.Category: This is a bug.E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.Performance or correctness regression from stable to nightly.
Description
While releasing teloxide 0.14.0 we encountered docs build failure on docs.rs: https://docs.rs/crate/teloxide/0.14.0/builds/1924379 (rust-lang/docs.rs#2780).
Bisecting this issue led to these findings:
- teloxide docs build fine on
nightly-2025-02-16(rust version 1.86.0-nightly (9cd60bd 2025-02-15)) - starting with
nightly-2025-02-17(rust version 1.87.0-nightly (5bc6231 2025-02-16) docs build fails with:error: unresolved link to `adaptors::AutoSend` --> crates/teloxide-core/src/lib.rs:51:19 | 51 | //! [`AutoSend`]: adaptors::AutoSend | ^^^^^^^^^^^^^^^^^^ no item named `AutoSend` in module `adaptors` | note: the lint level is defined here --> crates/teloxide-core/src/lib.rs:80:49 | 80 | #![cfg_attr(all(feature = "full", docsrs), deny(rustdoc::broken_intra_doc_links))] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error: could not document `teloxide-core` - starting with
nightly-2025-03-12(rust version 1.87.0-nightly (6650252 2025-03-11)) docs build fails with: https://pastebin.com/TV4JcCD4 - issue persists on
nightly-2025-03-29
Reacted by LasterAlex, hirrolot and Сырцев Вадим Игоревич
Metadata
Metadata
Assignees
Labels
C-bugCategory: This is a bug.Category: This is a bug.E-needs-bisectionCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcCall for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustcT-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.regression-from-stable-to-nightlyPerformance or correctness regression from stable to nightly.Performance or correctness regression from stable to nightly.
Activity
Noratrieb commentedon Mar 29, 2025
Thank you for the report! It would be useful to more precisely bisect the regression using cargo-bisect-rustc to make it easier to figure out where exactly it regressed and ping the relevant people.
@rustbot label E-needs-bisection
shdwchn10 commentedon Mar 29, 2025
test.sh: (
cargo docsisn't a typo, but alias with correct feature flags enabled)cargo bisect-rustc --start=2025-03-11 --end=2025-03-12 --script ./test.sh:searched nightlies: from nightly-2025-03-11 to nightly-2025-03-12
regressed nightly: nightly-2025-03-12
searched commit range: 9fb94b3...6650252
regressed commit: 6650252
bisected with cargo-bisect-rustc v0.6.9
Host triple: x86_64-unknown-linux-gnu
Reproduce with:
cargo bisect-rustc --start=2025-02-16 --end=2025-02-17 -- docs(probably not relevant, since the first error seems to have been fixed):searched nightlies: from nightly-2025-02-16 to nightly-2025-02-17
regressed nightly: nightly-2025-02-17
searched commit range: 9cd60bd...5bc6231
regressed commit: 23032f3
bisected with cargo-bisect-rustc v0.6.9
Host triple: x86_64-unknown-linux-gnu
Reproduce with:
Noratrieb commentedon Mar 29, 2025
#136363 sounds relevant. @notriddle @GuillaumeGomez
notriddle commentedon Mar 29, 2025
The adaptors module doesn't seem to have an
AutoSenditem in it (no re-export of the type itself, and no wildcard exports).shdwchn10 commentedon Mar 29, 2025
Thanks!
AutoSendremoval from docs fixes first error, but second is still here.cargo bisect-rustc --start=2025-03-11 --end=2025-03-12 -- docs:searched nightlies: from nightly-2025-03-11 to nightly-2025-03-12
regressed nightly: nightly-2025-03-12
searched commit range: 9fb94b3...6650252
regressed commit: 6650252
bisected with cargo-bisect-rustc v0.6.9
Host triple: x86_64-unknown-linux-gnu
Reproduce with:
workingjubilee commentedon Mar 30, 2025
cc @oli-obk ?
fmease commentedon Mar 30, 2025
not a bug. You now need to slap
#[define_opaque(Opaque)]onto fns etc. defining the opaque typeOpaqueshdwchn10 commentedon Mar 30, 2025
Thank you, now docs compile without issues!